linux-kernel - Re: [PATCH] pwm: Rename GPIO set_rv callback back to its original name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <z7wqrfqvx5rtm6ztvwnb4po5dvabgb2lyse6nws6ojzjdr6k3e@qzpopioosaai>
Date: Tue, 12 Aug 2025 12:44:10 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Stephen Rothwell <sfr@...b.auug.org.au>, 
	linux-pwm@...r.kernel.org, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: Rename GPIO set_rv callback back to its original
 name

On Tue, Aug 12, 2025 at 10:14:59AM +0200, Geert Uytterhoeven wrote:
> As of commit d9d87d90cc0b10cd ("treewide: rename GPIO set callbacks back
> to their original names"), the .set_rv() callback no longer exists:
> 
>     drivers/pwm/core.c: In function ‘__pwmchip_add’:
>     drivers/pwm/core.c:2514:26: error: ‘struct gpio_chip’ has no member named ‘set_rv’
>      2514 |                         .set_rv = pwm_gpio_set,
> 	  |                          ^~~~~~
>     drivers/pwm/core.c:2514:35: error: initialization of ‘int (*)(struct gpio_chip *, unsigned int)’ from incompatible pointer type ‘int (*)(struct gpio_chip *, unsigned int,  int)’ [-Werror=incompatible-pointer-types]
>      2514 |                         .set_rv = pwm_gpio_set,
> 	  |                                   ^~~~~~~~~~~~
>     drivers/pwm/core.c:2514:35: note: (near initialization for ‘(anonymous).direction_input’)
> 
> Fixes: 1c84bb7fc0ad5841 ("pwm: Provide a gpio device for waveform drivers")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Probably to be folded into the original commit, when pwm/for-next is
> rebased to v6.17-rc1.

That's what I did, before seeing your patch. Note that the Fixes line
isn't accurate, because it only gets wrong when it's merged in a tree
that contains d9d87d90cc0b ("treewide: rename GPIO set callbacks back to
their original names"). I don't know in which tree you found the two
commits together (I think Stephen fixed it for next?), but then
technically the merge commit would be at fault.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)