linux-kernel - Re: [PATCH v2] HID: lg-g15 - Add support for Logitech G13.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd294a60-1696-4ba0-8b25-ea259e8ccfb5@web.de>
Date: Tue, 12 Aug 2025 13:51:03 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: "Leo L. Schwab" <ewhac@...ac.org>, linux-input@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Benjamin Tissoires <bentiss@...nel.org>, Hans de Goede <hansg@...nel.org>,
 Jiri Kosina <jikos@...nel.org>, Kate Hsuan <hpa@...hat.com>
Subject: Re: [PATCH v2] HID: lg-g15 - Add support for Logitech G13.

…
> +++ b/drivers/hid/hid-ids.h
…
> +static int lg_g13_event(struct lg_g15_data *g15, u8 const *data)
> +{
…
> +#ifdef CONFIG_LEDS_BRIGHTNESS_HW_CHANGED
…
> +	if (hw_brightness_changed) {
> +		led_classdev_notify_brightness_hw_changed(
> +			&g15->leds[0].cdev,
> +			TEST_BIT(rep->keybits, 23) ? LED_FULL : LED_OFF);
> +	}
> +#endif
…
> +static void lg_g13_init_input_dev(struct hid_device *hdev,
> +				  struct input_dev *input, const char *name,
> +				  struct input_dev *input_js, const char *name_js)
> +{
…
> +	for (int i = 0;  i < ARRAY_SIZE(g13_keys_for_bits);  ++i) {
> +		if (g13_keys_for_bits[i]) {
> +			input_set_capability(input, EV_KEY, g13_keys_for_bits[i]);
> +		}
> +	}
…
> +	for (int i = 0;  i < ARRAY_SIZE(g13_keys_for_bits_js);  ++i) {
> +		if (g13_keys_for_bits_js[i]) {
> +			input_set_capability(input_js, EV_KEY, g13_keys_for_bits_js[i]);
> +		}
> +	}
…

May curly brackets be omitted at selected source code places?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17-rc1#n197

Regards,
Markus