linux-kernel - Re: [PATCH v2] HID: lg-g15 - Add support for Logitech G13.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3bc0b091-b23a-4245-81b0-da7e561cbc81@web.de>
Date: Tue, 12 Aug 2025 14:55:23 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: "Leo L. Schwab" <ewhac@...ac.org>, linux-input@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Benjamin Tissoires <bentiss@...nel.org>, Hans de Goede <hansg@...nel.org>,
 Jiri Kosina <jikos@...nel.org>, Kate Hsuan <hpa@...hat.com>
Subject: Re: [PATCH v2] HID: lg-g15 - Add support for Logitech G13.

…
> +++ b/drivers/hid/hid-lg-g15.c
…
> +static int lg_g13_get_leds_state(struct lg_g15_data *g15)
> +{
…
> +	for (int i = LG_G15_MACRO_PRESET1;  i < LG_G15_LED_MAX;  ++i)
…
+static int lg_g13_mkey_led_set(struct led_classdev *led_cdev, enum led_brightness brightness)
+{
…
> +	for (i = LG_G15_MACRO_PRESET1;  i < LG_G15_LED_MAX;  ++i) {
…

Please reconsider the usage of double space characters at some source code places.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.17-rc1#n234

Regards,
Markus