linux-kernel - Re: [PATCH v2] HID: lg-g15 - Add support for Logitech G13.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202508130759.HscxexZX-lkp@intel.com>
Date: Wed, 13 Aug 2025 08:11:48 +0800
From: kernel test robot <lkp@...el.com>
To: "Leo L. Schwab" <ewhac@...ac.org>, Hans de Goede <hansg@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, Kate Hsuan <hpa@...hat.com>,
	"Leo L. Schwab" <ewhac@...ac.org>, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: lg-g15 - Add support for Logitech G13.

Hi Leo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on hid/for-next]
[also build test WARNING on linus/master v6.17-rc1 next-20250812]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Leo-L-Schwab/HID-lg-g15-Add-support-for-Logitech-G13/20250812-151139
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link:    https://lore.kernel.org/r/20250812065327.515098-2-ewhac%40ewhac.org
patch subject: [PATCH v2] HID: lg-g15 - Add support for Logitech G13.
config: arm-randconfig-004-20250813 (https://download.01.org/0day-ci/archive/20250813/202508130759.HscxexZX-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250813/202508130759.HscxexZX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508130759.HscxexZX-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/hid/hid-lg-g15.c: In function 'lg_g13_event':
>> drivers/hid/hid-lg-g15.c:660:7: warning: unused variable 'hw_brightness_changed' [-Wunused-variable]
     bool hw_brightness_changed;
          ^~~~~~~~~~~~~~~~~~~~~

vim +/hw_brightness_changed +660 drivers/hid/hid-lg-g15.c

   655	
   656	static int lg_g13_event(struct lg_g15_data *g15, u8 const *data)
   657	{
   658		struct g13_input_report const * const rep = (struct g13_input_report *) data;
   659		int i, val;
 > 660		bool hw_brightness_changed;
   661	
   662		/*
   663		 * Main macropad and menu keys.
   664		 * Emit key events defined for each bit position.
   665		 */
   666		for (i = 0;  i < ARRAY_SIZE(g13_keys_for_bits);  ++i) {
   667			if (g13_keys_for_bits[i]) {
   668				val = TEST_BIT(rep->keybits, i);
   669				input_report_key(g15->input, g13_keys_for_bits[i], val);
   670			}
   671		}
   672		input_sync(g15->input);
   673	
   674		/*
   675		 * Joystick.
   676		 * Emit button and deflection events.
   677		 */
   678		for (i = 0;  i < ARRAY_SIZE(g13_keys_for_bits_js);  ++i) {
   679			if (g13_keys_for_bits_js[i]) {
   680				val = TEST_BIT(rep->keybits, i + 33);
   681				input_report_key(g15->input_js, g13_keys_for_bits_js[i], val);
   682			}
   683		}
   684		input_report_abs(g15->input_js, ABS_X, rep->joy_x);
   685		input_report_abs(g15->input_js, ABS_Y, rep->joy_y);
   686		input_sync(g15->input_js);
   687	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki