[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250813142814.31576-1-shankari.ak0208@gmail.com>
Date: Wed, 13 Aug 2025 19:58:14 +0530
From: Shankari Anand <shankari.ak0208@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>,
Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
linux-kernel@...r.kernel.org,
rust-for-linux@...r.kernel.org,
Boqun Feng <boqun.feng@...il.com>,
Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <lossin@...nel.org>,
Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>,
Trevor Gross <tmgross@...ch.edu>
Subject: "Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref"
On Fri, Aug 01, 2025 at 10:36:44AM +0200, Danilo Krummrich wrote:
> >
> >> NIT: Please don't top post. [1]
> >
> >> [1] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
> >
> > Apologies, I’ll make sure to follow the interleaved style.
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
> > [2] https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
> > [3] https://lore.kernel.org/rust-for-linux/20250716090712.809750-1-shankari.ak0208@gmail.com/
> > [4] https://lore.kernel.org/rust-for-linux/20250716091158.812860-1-shankari.ak0208@gmail.com/
> > [5] https://lore.kernel.org/rust-for-linux/20250716091827.816971-1-shankari.ak0208@gmail.com/
> > [6] https://lore.kernel.org/rust-for-linux/20250717072724.14602-1-shankari.ak0208@gmail.com/
> > [7] https://lore.kernel.org/rust-for-linux/20250717073108.14943-1-shankari.ak0208@gmail.com/
>
> Ok, I see what happened. :)
>
> I think you may have misunderstood the suggested of splitting things "by
> subsystem". Let's take [7] and [8] for instance.
>
> In [7] you update all the samples, regardless of their subsystem affinity and
> [8] updates everything under rust/kernel/.
>
> However, the idea was to send a separate patch per maintainers entry / tree,
> such that all patches can be picked in the corresponding tree.
>
I understood my mistake now. Thanks for clarifying!
I'll split it out correctly and resend them.
> For instance, one patch should be everything that goes through driver-core:
> auxiliary, PCI (incl. sample), platform (incl. sample), device, devres.
>
> Then you have another patch for only DMA (incl. sample), etc.
>
This particular patch in the series is restricted to inclusion of only gpu driver files.
Can this be picked up separately or should I be merging it with any other driver?
> Can you please resend accordingly? Ideally, wait for -rc1 to be out, or base
> your changes on -next.
>
> [8] https://lore.kernel.org/lkml/20250717073450.15090-1-shankari.ak0208@gmail.com/
Thanks and regards,
Shankari
Powered by blists - more mailing lists