linux-kernel - Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports from sync::aref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DBQYD7G5SOZA.2MSKKQWXTPCBB@kernel.org>
Date: Fri, 01 Aug 2025 10:36:44 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Shankari Anand" <shankari.ak0208@...il.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard"
 <mripard@...nel.org>, "Thomas Zimmermann" <tzimmermann@...e.de>, "David
 Airlie" <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Miguel
 Ojeda" <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>,
 <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>, "Boqun
 Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>
Subject: Re: [PATCH 2/7] rust: gpu: update ARef and AlwaysRefCounted imports
 from sync::aref

On Thu Jul 31, 2025 at 7:50 PM CEST, Shankari Anand wrote:
> On Thu Jul 31, 2025 at 14:54 UTC, Danilo Krummrich wrote:
>>
>> Ok, did you send the other ones already? I don't see them anywhere.
>
> The commit 07dad44aa9a9 ("rust: kernel: move ARef and AlwaysRefCounted
> to sync::aref ") refers to the patch where ARef and AlwaysRefCounted
> were moved into a different file. [1]
> To update the call-sites accordingly, I was advised to split the
> changes by subsystem so each patch could be reviewed and acked by the
> respective maintainers. [2]
> These patches are all part of that same effort, although they aren't
> shown as a formal series since the subject lines vary to reflect the
> specific files they touch. [3] [4] [5] [6] [7]
>
>> NIT: Please don't top post. [1]
>
>> [1] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
>
> Apologies, I’ll make sure to follow the interleaved style.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=07dad44aa9a93b16af19e8609a10b241c352b440
> [2] https://lore.kernel.org/rust-for-linux/CANiq72=NSRMV_6UxXVgkebmWmbgN4i=sfRszr-G+x3W5A4DYOg@mail.gmail.com/T/#u
> [3] https://lore.kernel.org/rust-for-linux/20250716090712.809750-1-shankari.ak0208@gmail.com/
> [4] https://lore.kernel.org/rust-for-linux/20250716091158.812860-1-shankari.ak0208@gmail.com/
> [5] https://lore.kernel.org/rust-for-linux/20250716091827.816971-1-shankari.ak0208@gmail.com/
> [6] https://lore.kernel.org/rust-for-linux/20250717072724.14602-1-shankari.ak0208@gmail.com/
> [7] https://lore.kernel.org/rust-for-linux/20250717073108.14943-1-shankari.ak0208@gmail.com/

Ok, I see what happened. :)

I think you may have misunderstood the suggested of splitting things "by
subsystem". Let's take [7] and [8] for instance.

In [7] you update all the samples, regardless of their subsystem affinity and
[8] updates everything under rust/kernel/.

However, the idea was to send a separate patch per maintainers entry / tree,
such that all patches can be picked in the corresponding tree.

For instance, one patch should be everything that goes through driver-core:
auxiliary, PCI (incl. sample), platform (incl. sample), device, devres.

Then you have another patch for only DMA (incl. sample), etc.

Can you please resend accordingly? Ideally, wait for -rc1 to be out, or base
your changes on -next.

[8] https://lore.kernel.org/lkml/20250717073450.15090-1-shankari.ak0208@gmail.com/