linux-kernel - Re: [PATCH v14 3/3] rust: replace `CStr` with `core::ffi::CStr`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9=ttX3tYzVq9Kb3Qfx+D+i5_Q7Q-rCHAEpH+fCFgF8AxQ@mail.gmail.com>
Date: Wed, 13 Aug 2025 11:46:20 -0400
From: Tamir Duberstein <tamird@...il.com>
To: Benno Lossin <lossin@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Luis Chamberlain <mcgrof@...nel.org>, Russ Weight <russ.weight@...ux.dev>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>, 
	Waiman Long <longman@...hat.com>, Nathan Chancellor <nathan@...nel.org>, 
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>, Bill Wendling <morbo@...gle.com>, 
	Justin Stitt <justinstitt@...gle.com>, Christian Brauner <brauner@...nel.org>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	llvm@...ts.linux.dev
Subject: Re: [PATCH v14 3/3] rust: replace `CStr` with `core::ffi::CStr`

On Wed, Aug 13, 2025 at 10:40 AM Benno Lossin <lossin@...nel.org> wrote:
>
> On Wed Aug 13, 2025 at 4:06 PM CEST, Tamir Duberstein wrote:
> > On Tue, Aug 12, 2025 at 3:50 AM Benno Lossin <lossin@...nel.org> wrote:
> >> On Thu Jul 10, 2025 at 4:53 PM CEST, Tamir Duberstein wrote:
> >> > +/// Extensions to [`CStr`].
> >> > +pub trait CStrExt {
> >>
> >> Should we make this trait sealed?
> >
> > We can -- but is it harmful for someone to implement? I think probably not.
>
> I don't think anything aside from `CStr` should implement it, so I'd say
> we make it sealed. There are also safe functions that return raw
> pointers & an implementation could just return a bogus pointer...

Done in v15.