linux-kernel - Re: [PATCH net-next v5 5/5] selftests/net: add vxlan localbind selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e8ba3fa-81b6-4921-a02b-1d6da756ecec@gmail.com>
Date: Wed, 13 Aug 2025 17:49:31 +0200
From: Richard Gobert <richardbgobert@...il.com>
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 donald.hunter@...il.com, andrew+netdev@...n.ch, dsahern@...nel.org,
 shuah@...nel.org, daniel@...earbox.net, jacob.e.keller@...el.com,
 razor@...ckwall.org, petrm@...dia.com, menglong8.dong@...il.com,
 martin.lau@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 5/5] selftests/net: add vxlan localbind
 selftest

Ido Schimmel wrote:
> On Tue, Aug 12, 2025 at 02:51:55PM +0200, Richard Gobert wrote:
>> Test to make sure the localbind netlink option works
>> in VXLAN interfaces.
> 
> Thanks for adding a test. A few clerical comments:
> 
> 1. Indentation is inconsistent. Please convert to 8 characters tabs.
> 
> 2. netdev CI started running shellcheck. I don't think you can eliminate
> all the errors, but some can be easily fixed.
> 
> 3. There's a blank line at the end of the file that should be removed.

I'll take a look. Thanks.