linux-kernel - Re: [PATCH v8 30/30] KVM: selftests: TDX: Test LOG_DIRTY_PAGES flag to a non-GUEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <689cb8db46492_20a6d929493@iweiny-mobl.notmuch>
Date: Wed, 13 Aug 2025 11:10:03 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Sagi Shahar <sagis@...gle.com>, <linux-kselftest@...r.kernel.org>, "Paolo
 Bonzini" <pbonzini@...hat.com>, Shuah Khan <shuah@...nel.org>, "Sean
 Christopherson" <seanjc@...gle.com>, Ackerley Tng <ackerleytng@...gle.com>,
	Ryan Afranji <afranji@...gle.com>, Andrew Jones <ajones@...tanamicro.com>,
	Isaku Yamahata <isaku.yamahata@...el.com>, Erdem Aktas
	<erdemaktas@...gle.com>, Rick Edgecombe <rick.p.edgecombe@...el.com>, "Roger
 Wang" <runanwang@...gle.com>, Binbin Wu <binbin.wu@...ux.intel.com>, "Oliver
 Upton" <oliver.upton@...ux.dev>, "Pratik R. Sampat"
	<pratikrajesh.sampat@....com>, Reinette Chatre <reinette.chatre@...el.com>,
	Ira Weiny <ira.weiny@...el.com>
CC: <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>, Yan Zhao
	<yan.y.zhao@...el.com>
Subject: Re: [PATCH v8 30/30] KVM: selftests: TDX: Test LOG_DIRTY_PAGES flag
 to a non-GUEST_MEMFD memslot

Sagi Shahar wrote:
> From: Yan Zhao <yan.y.zhao@...el.com>
> 
> Add a selftest to verify that adding flag KVM_MEM_LOG_DIRTY_PAGES to a
> !KVM_MEM_GUEST_MEMFD memslot does not produce host errors in TDX.

I'll pick on this patch for a general comment in for the series.

Most of the commit messages are light on the 'why' a patch exists.  It may
seem obvious that adding a test is to test some functionality.  But that
is not always the full story.

For example, here it would be nice for folks in the future to see what bug
fix this was testing.  Then if it starts failing we all know where to
start looking for the regression.

Ira

[snip]