linux-kernel - Re: [patch 07/11] entry: Cleanup header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE7dp2pxxKWdNJkwZZDw2GmR6vH8YVMGcTm55u1pxVygaeNydw@mail.gmail.com>
Date: Wed, 13 Aug 2025 21:09:41 +0400
From: Giorgi Tchankvetadze <giorgitchankvetadze1997@...il.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, Michael Jeanson <mjeanson@...icios.com>, 
	Peter Zijlstra <peterz@...radead.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	"Paul E. McKenney" <paulmck@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Wei Liu <wei.liu@...nel.org>, 
	Jens Axboe <axboe@...nel.dk>
Subject: Re: [patch 07/11] entry: Cleanup header

Typo in kernel-doc:
In irq-entry-common.h the doc line reads Pointer to currents pt_regs —
should be Pointer to current's pt_regs (or Pointer to current->pt_regs
depending on local style).


 Stray blank/trailing whitespace:
In entry-common.h there is an extra blank line inserted after the
ARCH_SYSCALL_WORK_ENTER) macro continuation — remove the stray blank
to avoid style/noise.

On Wed, Aug 13, 2025 at 8:39 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> Cleanup the include ordering, kernel-doc and other trivialities before
> making further changes.
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Peter Zijlstra <peterz@...radead.org>
> ---
>  include/linux/entry-common.h     |    8 ++++----
>  include/linux/irq-entry-common.h |    2 ++
>  2 files changed, 6 insertions(+), 4 deletions(-)
>
> --- a/include/linux/entry-common.h
> +++ b/include/linux/entry-common.h
> @@ -3,11 +3,11 @@
>  #define __LINUX_ENTRYCOMMON_H
>
>  #include <linux/irq-entry-common.h>
> +#include <linux/livepatch.h>
>  #include <linux/ptrace.h>
> +#include <linux/resume_user_mode.h>
>  #include <linux/seccomp.h>
>  #include <linux/sched.h>
> -#include <linux/livepatch.h>
> -#include <linux/resume_user_mode.h>
>
>  #include <asm/entry-common.h>
>  #include <asm/syscall.h>
> @@ -37,6 +37,7 @@
>                                  SYSCALL_WORK_SYSCALL_AUDIT |           \
>                                  SYSCALL_WORK_SYSCALL_USER_DISPATCH |   \
>                                  ARCH_SYSCALL_WORK_ENTER)
> +
>  #define SYSCALL_WORK_EXIT      (SYSCALL_WORK_SYSCALL_TRACEPOINT |      \
>                                  SYSCALL_WORK_SYSCALL_TRACE |           \
>                                  SYSCALL_WORK_SYSCALL_AUDIT |           \
> @@ -61,8 +62,7 @@
>   */
>  void syscall_enter_from_user_mode_prepare(struct pt_regs *regs);
>
> -long syscall_trace_enter(struct pt_regs *regs, long syscall,
> -                        unsigned long work);
> +long syscall_trace_enter(struct pt_regs *regs, long syscall, unsigned long work);
>
>  /**
>   * syscall_enter_from_user_mode_work - Check and handle work before invoking
> --- a/include/linux/irq-entry-common.h
> +++ b/include/linux/irq-entry-common.h
> @@ -68,6 +68,7 @@ static __always_inline bool arch_in_rcu_
>
>  /**
>   * enter_from_user_mode - Establish state when coming from user mode
> + * @regs:      Pointer to currents pt_regs
>   *
>   * Syscall/interrupt entry disables interrupts, but user mode is traced as
>   * interrupts enabled. Also with NO_HZ_FULL RCU might be idle.
> @@ -357,6 +358,7 @@ irqentry_state_t noinstr irqentry_enter(
>   * Conditional reschedule with additional sanity checks.
>   */
>  void raw_irqentry_exit_cond_resched(void);
> +
>  #ifdef CONFIG_PREEMPT_DYNAMIC
>  #if defined(CONFIG_HAVE_PREEMPT_DYNAMIC_CALL)
>  #define irqentry_exit_cond_resched_dynamic_enabled     raw_irqentry_exit_cond_resched
>
>