linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sm8450: Fix address for usb controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40546666-1a49-41a0-a1e4-ad3af4ddc81c@kernel.org>
Date: Wed, 13 Aug 2025 20:42:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Krishna Kurapati <krishna.kurapati@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] arm64: dts: qcom: sm8450: Fix address for usb
 controller node

On 13/08/2025 18:09, Krishna Kurapati wrote:
> Correct the address in usb controller node to fix the following warning:
> 
> Warning (simple_bus_reg): /soc@...sb@...8800: simple-bus unit address
> format error, expected "a600000"
> 
> Fixes: c5a87e3a6b3e ("arm64: dts: qcom: sm8450: Flatten usb controller node")
> Cc: stable@...r.kernel.org
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508121834.953Mvah2-lkp@intel.com/
> Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
> ---
> This change was tested with W=1 and the reported issue is not seen.
> Also didn't add RB Tag received from Neil Armstrong since there is a
> change in commit text.


Really? That is NOT the reason to drop people's review?

Apart from that, THERE IS NO change in commit txt, so dropping tags is
not justified by any means. It's really not acceptable.

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here. However, there's no need to repost
patches *only* to add the tags. The upstream maintainer will do that for
tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577


Best regards,
Krzysztof