linux-kernel - Re: [PATCH v7 08/13] dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc185397-2588-4dec-8bca-c4ebd34919eb@kernel.org>
Date: Wed, 13 Aug 2025 21:08:08 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hans Zhang <hans.zhang@...tech.com>, "Rob Herring (Arm)" <robh@...nel.org>
Cc: mpillai@...ence.com, cix-kernel-upstream@...tech.com,
 lpieralisi@...nel.org, bhelgaas@...gle.com, devicetree@...r.kernel.org,
 conor+dt@...nel.org, linux-pci@...r.kernel.org, mani@...nel.org,
 kw@...ux.com, kwilczynski@...nel.org, krzk+dt@...nel.org,
 fugang.duan@...tech.com, guoyin.chen@...tech.com, peter.chen@...tech.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 08/13] dt-bindings: PCI: Add CIX Sky1 PCIe Root Complex
 bindings

On 13/08/2025 11:12, Hans Zhang wrote:
> 
> 
> On 2025/8/13 16:31, Rob Herring (Arm) wrote:
>> EXTERNAL EMAIL
>>
>> On Wed, 13 Aug 2025 12:23:26 +0800, hans.zhang@...tech.com wrote:
>>> From: Hans Zhang <hans.zhang@...tech.com>
>>>
>>> Document the bindings for CIX Sky1 PCIe Controller configured in
>>> root complex mode with five root port.
>>>
>>> Supports 4 INTx, MSI and MSI-x interrupts from the ARM GICv3 controller.
>>>
>>> Signed-off-by: Hans Zhang <hans.zhang@...tech.com>
>>> ---
>>>   .../bindings/pci/cix,sky1-pcie-host.yaml      | 79 +++++++++++++++++++
>>>   1 file changed, 79 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.yaml
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dtb: /: 'compatible' is a required property
>>          from schema $id: http://devicetree.org/schemas/root-node.yaml#
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/cix,sky1-pcie-host.example.dtb: /: 'model' is a required property
>>          from schema $id: http://devicetree.org/schemas/root-node.yaml#
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250813042331.1258272-9-hans.zhang@cixtech.com
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your schema.
>>
> 
> Dear Rob,
> 
> I'm very sorry. No errors were detected on my PC. I'll check my local 
> environment and fix this issue in the next version.
> 
> If I have done anything wrong, please remind me.

Your code is not correct. You are not supposed to have there root node.
Please open ANY (most recent preferably) other binding and look how it
is done there.

Best regards,
Krzysztof