linux-kernel - Re: [PATCH v1] PM: Support aborting suspend during filesystem sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202508140303.9c38ncEh-lkp@intel.com>
Date: Thu, 14 Aug 2025 03:21:52 +0800
From: kernel test robot <lkp@...el.com>
To: Samuel Wu <wusamuel@...gle.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, Pavel Machek <pavel@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Danilo Krummrich <dakr@...nel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Lukasz Luba <lukasz.luba@....com>
Cc: oe-kbuild-all@...ts.linux.dev, Samuel Wu <wusamuel@...gle.com>,
	Saravana Kannan <saravanak@...gle.com>, kernel-team@...roid.com,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] PM: Support aborting suspend during filesystem sync

Hi Samuel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/bleeding-edge linus/master v6.17-rc1 next-20250813]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Samuel-Wu/PM-Support-aborting-suspend-during-filesystem-sync/20250813-072435
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20250812232126.1814253-1-wusamuel%40google.com
patch subject: [PATCH v1] PM: Support aborting suspend during filesystem sync
config: arm64-randconfig-r132-20250813 (https://download.01.org/0day-ci/archive/20250814/202508140303.9c38ncEh-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.5.0
reproduce: (https://download.01.org/0day-ci/archive/20250814/202508140303.9c38ncEh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508140303.9c38ncEh-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> kernel/power/suspend.c:79:1: sparse: sparse: symbol 'suspend_fs_sync_lock' was not declared. Should it be static?
>> kernel/power/suspend.c:80:1: sparse: sparse: symbol 'suspend_fs_sync_complete' was not declared. Should it be static?
   kernel/power/suspend.c:104:54: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected int val @@     got restricted suspend_state_t [usertype] @@
   kernel/power/suspend.c:104:54: sparse:     expected int val
   kernel/power/suspend.c:104:54: sparse:     got restricted suspend_state_t [usertype]
   kernel/power/suspend.c:141:54: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected int val @@     got restricted suspend_state_t [usertype] @@
   kernel/power/suspend.c:141:54: sparse:     expected int val
   kernel/power/suspend.c:141:54: sparse:     got restricted suspend_state_t [usertype]
   kernel/power/suspend.c:202:19: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:202:47: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:203:19: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:203:51: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:208:26: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:208:65: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:215:42: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:215:51: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:216:38: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:217:51: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:215:72: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:240:34: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:240:73: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:241:27: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:241:59: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:246:34: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:246:69: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:247:21: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:247:42: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:537:33: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected int val @@     got restricted suspend_state_t [usertype] state @@
   kernel/power/suspend.c:537:33: sparse:     expected int val
   kernel/power/suspend.c:537:33: sparse:     got restricted suspend_state_t [usertype] state
   kernel/power/suspend.c:540:33: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected int val @@     got restricted suspend_state_t [usertype] state @@
   kernel/power/suspend.c:540:33: sparse:     expected int val
   kernel/power/suspend.c:540:33: sparse:     got restricted suspend_state_t [usertype] state
   kernel/power/suspend.c:610:57: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected int val @@     got restricted suspend_state_t [usertype] state @@
   kernel/power/suspend.c:610:57: sparse:     expected int val
   kernel/power/suspend.c:610:57: sparse:     got restricted suspend_state_t [usertype] state
   kernel/power/suspend.c:612:57: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected int val @@     got restricted suspend_state_t [usertype] state @@
   kernel/power/suspend.c:612:57: sparse:     expected int val
   kernel/power/suspend.c:612:57: sparse:     got restricted suspend_state_t [usertype] state
   kernel/power/suspend.c:650:52: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected int val @@     got restricted suspend_state_t [usertype] state @@
   kernel/power/suspend.c:650:52: sparse:     expected int val
   kernel/power/suspend.c:650:52: sparse:     got restricted suspend_state_t [usertype] state
   kernel/power/suspend.c:675:9: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:675:9: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:684:52: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected int val @@     got restricted suspend_state_t [usertype] state @@
   kernel/power/suspend.c:684:52: sparse:     expected int val
   kernel/power/suspend.c:684:52: sparse:     got restricted suspend_state_t [usertype] state
   kernel/power/suspend.c:685:9: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:685:9: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:708:13: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:708:22: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:708:39: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:708:48: sparse: sparse: restricted suspend_state_t degrades to integer
   kernel/power/suspend.c:711:9: sparse: sparse: restricted suspend_state_t degrades to integer

vim +/suspend_fs_sync_lock +79 kernel/power/suspend.c

    77	
    78	static bool suspend_fs_sync_queued;
  > 79	DEFINE_SPINLOCK(suspend_fs_sync_lock);
  > 80	DECLARE_COMPLETION(suspend_fs_sync_complete);
    81	void suspend_abort_fs_sync(void)
    82	{
    83		spin_lock(&suspend_fs_sync_lock);
    84		complete(&suspend_fs_sync_complete);
    85		spin_unlock(&suspend_fs_sync_lock);
    86	}
    87	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki