linux-kernel - Re: [PATCH v1] PM: Support aborting suspend during filesystem sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025081359-survey-sprinkled-e6dc@gregkh>
Date: Wed, 13 Aug 2025 07:53:32 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Samuel Wu <wusamuel@...gle.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
	Pavel Machek <pavel@...nel.org>, Danilo Krummrich <dakr@...nel.org>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Lukasz Luba <lukasz.luba@....com>,
	Saravana Kannan <saravanak@...gle.com>, kernel-team@...roid.com,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] PM: Support aborting suspend during filesystem sync

On Tue, Aug 12, 2025 at 04:21:23PM -0700, Samuel Wu wrote:
> +static bool suspend_fs_sync_queued;
> +DEFINE_SPINLOCK(suspend_fs_sync_lock);
> +DECLARE_COMPLETION(suspend_fs_sync_complete);
> +void suspend_abort_fs_sync(void)
> +{
> +	spin_lock(&suspend_fs_sync_lock);
> +	complete(&suspend_fs_sync_complete);
> +	spin_unlock(&suspend_fs_sync_lock);
> +}

Why no documentation for this public function that you added, but yet
you added documentation for a static function that no one can call?

thanks,

greg k-h