linux-kernel - Re: [PATCH v7 08/11] tee: add Qualcomm TEE driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202508140527.ighXikjo-lkp@intel.com>
Date: Thu, 14 Aug 2025 05:28:10 +0800
From: kernel test robot <lkp@...el.com>
To: Amirreza Zarrabi <amirreza.zarrabi@....qualcomm.com>,
	Jens Wiklander <jens.wiklander@...aro.org>,
	Sumit Garg <sumit.garg@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	Apurupa Pattapu <quic_apurupa@...cinc.com>,
	Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	Christian König <christian.koenig@....com>
Cc: oe-kbuild-all@...ts.linux.dev, Harshal Dev <quic_hdev@...cinc.com>,
	linux-arm-msm@...r.kernel.org, op-tee@...ts.trustedfirmware.org,
	linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
	linux-doc@...r.kernel.org,
	Amirreza Zarrabi <amirreza.zarrabi@....qualcomm.com>,
	Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v7 08/11] tee: add Qualcomm TEE driver

Hi Amirreza,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 2674d1eadaa2fd3a918dfcdb6d0bb49efe8a8bb9]

url:    https://github.com/intel-lab-lkp/linux/commits/Amirreza-Zarrabi/tee-allow-a-driver-to-allocate-a-tee_device-without-a-pool/20250813-084152
base:   2674d1eadaa2fd3a918dfcdb6d0bb49efe8a8bb9
patch link:    https://lore.kernel.org/r/20250812-qcom-tee-using-tee-ss-without-mem-obj-v7-8-ce7a1a774803%40oss.qualcomm.com
patch subject: [PATCH v7 08/11] tee: add Qualcomm TEE driver
config: hexagon-randconfig-r072-20250814 (https://download.01.org/0day-ci/archive/20250814/202508140527.ighXikjo-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 3769ce013be2879bf0b329c14a16f5cb766f26ce)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250814/202508140527.ighXikjo-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508140527.ighXikjo-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/tee/qcomtee/user_obj.c:384:12: warning: format specifies type 'unsigned long' but the argument has type 'u64' (aka 'unsigned long long') [-Wformat]
     383 |                                        &qcomtee_user_object_ops, "uo-%lu",
         |                                                                      ~~~
         |                                                                      %llu
     384 |                                        param->u.objref.id);
         |                                        ^~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +384 drivers/tee/qcomtee/user_obj.c

   355	
   356	/**
   357	 * qcomtee_user_param_to_object() - OBJREF parameter to &struct qcomtee_object.
   358	 * @object: object returned.
   359	 * @param: TEE parameter.
   360	 * @ctx: context in which the conversion should happen.
   361	 *
   362	 * @param is an OBJREF with %QCOMTEE_OBJREF_FLAG_USER flags.
   363	 *
   364	 * Return: On success, returns 0; on failure, returns < 0.
   365	 */
   366	int qcomtee_user_param_to_object(struct qcomtee_object **object,
   367					 struct tee_param *param,
   368					 struct tee_context *ctx)
   369	{
   370		struct qcomtee_user_object *user_object __free(kfree) = NULL;
   371		int err;
   372	
   373		user_object = kzalloc(sizeof(*user_object), GFP_KERNEL);
   374		if (!user_object)
   375			return -ENOMEM;
   376	
   377		user_object->ctx = ctx;
   378		user_object->object_id = param->u.objref.id;
   379		/* By default, always notify userspace upon release. */
   380		user_object->notify = true;
   381		err = qcomtee_object_user_init(&user_object->object,
   382					       QCOMTEE_OBJECT_TYPE_CB,
   383					       &qcomtee_user_object_ops, "uo-%lu",
 > 384					       param->u.objref.id);
   385		if (err)
   386			return err;
   387		/* Matching teedev_ctx_put() is in qcomtee_user_object_release(). */
   388		teedev_ctx_get(ctx);
   389	
   390		*object = &no_free_ptr(user_object)->object;
   391	
   392		return 0;
   393	}
   394	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki