linux-kernel - Re: [patch 07/11] entry: Cleanup header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ecte7vv9.ffs@tglx>
Date: Wed, 13 Aug 2025 23:30:18 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Michael Jeanson
 <mjeanson@...icios.com>, Peter Zijlstra <peterz@...radead.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, "Paul E. McKenney"
 <paulmck@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Wei Liu
 <wei.liu@...nel.org>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [patch 07/11] entry: Cleanup header

On Wed, Aug 13 2025 at 21:09, Giorgi Tchankvetadze wrote:

Please do not top-post and reply inline so there is context:

       https://people.kernel.org/tglx/notes-about-netiquette

> Typo in kernel-doc:
> In irq-entry-common.h the doc line reads Pointer to currents pt_regs —
> should be Pointer to current's pt_regs (or Pointer to current->pt_regs
> depending on local style).

Good point.

>  Stray blank/trailing whitespace:
> In entry-common.h there is an extra blank line inserted after the
> ARCH_SYSCALL_WORK_ENTER) macro continuation — remove the stray blank
> to avoid style/noise.

No.

>> @@ -37,6 +37,7 @@
>>                                  SYSCALL_WORK_SYSCALL_AUDIT |           \
>>                                  SYSCALL_WORK_SYSCALL_USER_DISPATCH |   \
>>                                  ARCH_SYSCALL_WORK_ENTER)

There is no continuation of the SYSCALL_WORK_ENTER macro.

>> +

And this is an empty new line to visually seperate SYSCALL_WORK_ENTER
from SYSCALL_WORK_EXIT.

>>  #define SYSCALL_WORK_EXIT      (SYSCALL_WORK_SYSCALL_TRACEPOINT |      \

No?

Thanks,

        tglx