linux-kernel - Re: [PATCH v3 1/7] ALSA: usb-audio: Add initial driver for TASCAM US-144MKII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ldnny60i.wl-tiwai@suse.de>
Date: Wed, 13 Aug 2025 10:34:21 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Šerif Rami <ramiserifpersia@...il.com>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org
Subject: Re: [PATCH v3 1/7] ALSA: usb-audio: Add initial driver for TASCAM US-144MKII

On Tue, 12 Aug 2025 15:22:03 +0200,
Šerif Rami wrote:
> 
> diff --git a/sound/usb/usx2y/us144mkii.h b/sound/usb/usx2y/us144mkii.h
> new file mode 100644
> index 000000000000..38731a1285ea
> --- /dev/null
> +++ b/sound/usb/usx2y/us144mkii.h
> @@ -0,0 +1,38 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +// Copyright (c) 2025 Šerif Rami <ramiserifpersia@...il.com>
> +
> + #ifndef __US144MKII_H
> + #define __US144MKII_H
> +
> + #include <linux/usb.h>
> + #include <sound/core.h>
> + #include <sound/initval.h>
> +
> + #define DRIVER_NAME "us144mkii"
> +
> +/* --- USB Device Identification --- */
> + #define USB_VID_TASCAM 0x0644
> + #define USB_PID_TASCAM_US144 0x800f
> + #define USB_PID_TASCAM_US144MKII 0x8020
> +
> +/* --- USB Control Message Protocol --- */
> + #define RT_D2H_VENDOR_DEV (USB_DIR_IN|USB_TYPE_VENDOR|USB_RECIP_DEVICE)
> + #define VENDOR_REQ_MODE_CONTROL 0x49
> + #define MODE_VAL_HANDSHAKE_READ 0x0000
> + #define USB_CTRL_TIMEOUT_MS 1000

Drop a space at the beginning of lines here (which will be corrected
in later patches).


thanks,

Takashi