linux-kernel - Re: [PATCH v4 2/2] arm64: dts: qcom: sm8450: Flatten usb controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa3c54d3-aa8b-4991-8709-89a8bf9eead1@oss.qualcomm.com>
Date: Wed, 13 Aug 2025 14:04:46 +0530
From: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-kernel@...r.kernel.org, neil.armstrong@...aro.org,
        devicetree@...r.kernel.org, Konrad Dybcio <konradybcio@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: sm8450: Flatten usb controller
 node



On 8/13/2025 12:57 PM, Krzysztof Kozlowski wrote:
> On 15/07/2025 07:27, Krishna Kurapati wrote:
>> Flatten usb controller node and update to using latest bindings
>> and flattened driver approach.
>>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8450-hdk.dts       |  5 --
>>   .../dts/qcom/sm8450-sony-xperia-nagara.dtsi   |  5 +-
>>   arch/arm64/boot/dts/qcom/sm8450.dtsi          | 57 +++++++++----------
>>   3 files changed, 27 insertions(+), 40 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> index 2ff40a120aad..0c6aa7ddf432 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
>> @@ -1199,11 +1199,6 @@ &usb_1 {
>>   	status = "okay";
>>   };
>>   
>> -&usb_1_dwc3 {
>> -	dr_mode = "otg";
>> -	usb-role-switch;
>> -};
>> -
>>   &usb_1_dwc3_hs {
>>   	remote-endpoint = <&pmic_glink_hs_in>;
>>   };
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
>> index cc1335a07a35..6bd315e10992 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi
>> @@ -781,11 +781,8 @@ &uart7 {
>>   };
>>   
>>   &usb_1 {
>> -	status = "okay";
>> -};
>> -
>> -&usb_1_dwc3 {
>>   	dr_mode = "peripheral";
>> +	status = "okay";
>>   };
>>   
>>   &usb_1_hsphy {
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index 54c6d0fdb2af..89dbac3bdd2b 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -5417,12 +5417,9 @@ opp-202000000 {
>>   		};
>>   
>>   		usb_1: usb@...8800 {
>> -			compatible = "qcom,sm8450-dwc3", "qcom,dwc3";
>> -			reg = <0 0x0a6f8800 0 0x400>;
>> +			compatible = "qcom,sm8450-dwc3", "qcom,snps-dwc3";
>> +			reg = <0 0x0a600000 0 0xfc100>;
> 
> 
> So this was never checked. Can you start using tools before you send
> code upstream?
> 
> 

Hi Krzysztof,

  Apologies. I didn't compile it with W=1 previously. When I did after 
the kernel test robot complained, I saw the issue.

  Also I rebased it on top of latest linux next where I see the 
flattened patch is present.

Regards,
Krishna,