[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6f46e420-832a-4c6e-b1e9-d797b0425834@kernel.org>
Date: Wed, 13 Aug 2025 11:24:50 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Aleksander Jan Bajkowski <olek2@...pl>, jdelvare@...e.com,
linux@...ck-us.net, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, fe@....tdt.de, linux-hwmon@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml
On 13/08/2025 11:19, Aleksander Jan Bajkowski wrote:
> +---
> +$id: http://devicetree.org/schemas/hwmon/lantiq,cputemp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq cpu temperature sensor
> +
> +maintainers:
> + - Florian Eckert <fe@....tdt.de>
> +
> +properties:
> + compatible:
> + const: lantiq,cputemp
> +
> +required:
> + - compatible
> +
I think this reads and writs to some IOMEM space, so you really need
here 'reg'. That's the problem with such old bindings... binding is
broken, DTS is half-baked or non-existing, driver has 20 years.
BTW, why converting this old binding? Do you have any interest in
actually running MIPS?
I assume you did not check Rob's dt-convert branch to avoid
duplicated... because he did convert EXACTLY this binding. And more from
Lantiq.
Best regards,
Krzysztof
Powered by blists - more mailing lists