[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9d0ebfe1-e92b-45e0-baf1-3d6d2ce4c568@wp.pl>
Date: Wed, 13 Aug 2025 11:52:54 +0200
From: Aleksander Jan Bajkowski <olek2@...pl>
To: Krzysztof Kozlowski <krzk@...nel.org>, jdelvare@...e.com,
linux@...ck-us.net, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, fe@....tdt.de, linux-hwmon@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: convert lantiq-cputemp to yaml
Hi Krzysztof,
On 8/13/25 11:24, Krzysztof Kozlowski wrote:
> On 13/08/2025 11:19, Aleksander Jan Bajkowski wrote:
>> +---
>> +$id: http://devicetree.org/schemas/hwmon/lantiq,cputemp.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Lantiq cpu temperature sensor
>> +
>> +maintainers:
>> + - Florian Eckert <fe@....tdt.de>
>> +
>> +properties:
>> + compatible:
>> + const: lantiq,cputemp
>> +
>> +required:
>> + - compatible
>> +
> I think this reads and writs to some IOMEM space, so you really need
> here 'reg'. That's the problem with such old bindings... binding is
> broken, DTS is half-baked or non-existing, driver has 20 years.
These devices are not so old. They support multithreading. In the case
of NAT, they can process up to 700Mbps of traffic.
>
> BTW, why converting this old binding? Do you have any interest in
> actually running MIPS?
I have several devices with Lantiq SoC (xRX100, xRX200 and xRX330).
They are supported by OpenWRT. These are the only devices with mainline
Linux that support ADSL2+ and VDSL2. I would like to add the missing dts
files for the xRX200 and xRX330 families. I have started fixing the errors
reported by the dtbs_check script.
Downstream dts:
https://github.com/openwrt/openwrt/blob/main/target/linux/lantiq/files/arch/mips/boot/dts/lantiq/vr9.dtsi#L29
>
> I assume you did not check Rob's dt-convert branch to avoid
> duplicated... because he did convert EXACTLY this binding. And more from
> Lantiq.
Thanks, I didn't know that.
>
>
>
> Best regards,
> Krzysztof
Powered by blists - more mailing lists