linux-kernel - Re: [PATCH 2/3] iio: adc: ltc2497: add support for LTC2495

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vc+XjiRoV42zuZDpqsWKLN+5=uv3wLFMk6LGUagmhBMMg@mail.gmail.com>
Date: Wed, 13 Aug 2025 12:18:10 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Yusuf Alper Bilgin <y.alperbilgin@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, 
	Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Liam Beguin <liambeguin@...il.com>, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] iio: adc: ltc2497: add support for LTC2495

On Tue, Aug 12, 2025 at 7:09 PM Yusuf Alper Bilgin
<y.alperbilgin@...il.com> wrote:
>
> This updates the LTC2497 driver to also support the LTC2495.

...

> +#define LTC2497_CONVERSION_TIME_MS     150ULL

Why ULL? (Mainly why the 'L'/'LL'?)

...

>         if (time_elapsed < LTC2497_CONVERSION_TIME_MS) {
> -               /* delay if conversion time not passed
> -                * since last read or write
> -                */
> -               if (msleep_interruptible(
> -                   LTC2497_CONVERSION_TIME_MS - time_elapsed))
> +               /* delay if conversion time not passed since last read or write */
> +               if (msleep_interruptible(LTC2497_CONVERSION_TIME_MS - time_elapsed))
>                         return -ERESTARTSYS;
>
>                 return 0;
>         }
>
>         if (time_elapsed - LTC2497_CONVERSION_TIME_MS <= 0) {
> -               /* We're in automatic mode -
> -                * so the last reading is still not outdated
> -                */
> +               /* We're in automatic mode - so the last reading is still not outdated */
>                 return 0;
>         }

AFAICS these are unrelated changes. Please, strip them and if you
wish, create a new patch.

...

> -#define LTC2497_ENABLE                 0xA0

> +#define LTC2497_ENABLE 0xA0

Why?!

> -#define LTC2497_CONFIG_DEFAULT         LTC2497_ENABLE
> -#define LTC2497_CONVERSION_TIME_MS     150ULL

Unrelated.

-- 
With Best Regards,
Andy Shevchenko