linux-kernel - Re: [PATCH] media: imx296: Remove redundant semicolons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <175508029630.560048.7835285687538106544@ping.linuxembedded.co.uk>
Date: Wed, 13 Aug 2025 11:18:16 +0100
From: Kieran Bingham <kieran.bingham@...asonboard.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>, Liao Yuanhong <liaoyuanhong@...o.com>, Manivannan Sadhasivam <mani@...nel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Cc: Liao Yuanhong <liaoyuanhong@...o.com>
Subject: Re: [PATCH] media: imx296: Remove redundant semicolons

Quoting Liao Yuanhong (2025-08-13 10:47:46)
> Remove unnecessary semicolons.

Well ... there's only one so it's not plural ;-) but indeed this is very
redundant!


Reviewed-by: Kieran Bingham <kieran.bingham@...asonboard.com>

> 
> Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
> ---
>  drivers/media/i2c/imx296.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx296.c b/drivers/media/i2c/imx296.c
> index f3bec16b527c..cbbe0e7a37a9 100644
> --- a/drivers/media/i2c/imx296.c
> +++ b/drivers/media/i2c/imx296.c
> @@ -922,7 +922,7 @@ static int imx296_read_temperature(struct imx296 *sensor, int *temp)
>  
>         tmdout &= IMX296_TMDOUT_MASK;
>  
> -       /* T(��C) = 246.312 - 0.304 * TMDOUT */;
> +       /* T(��C) = 246.312 - 0.304 * TMDOUT */
>         *temp = 246312 - 304 * tmdout;
>  
>         return imx296_write(sensor, IMX296_TMDCTRL, 0, NULL);
> -- 
> 2.34.1
>