linux-kernel - Re: [PATCH v2 9/9] dt-bindings: mfd: twl: Add missing sub-nodes for TWL4030 & TWL603x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814162222.4173e3e8@akair>
Date: Thu, 14 Aug 2025 16:22:22 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Jihed Chaibi <jihed.chaibi.dev@...il.com>
Cc: linux-kernel@...r.kernel.org, peter.ujfalusi@...il.com,
 dmitry.torokhov@...il.com, robh@...nel.org, krzk+dt@...nel.org,
 lgirdwood@...il.com, tiwai@...e.com, conor+dt@...nel.org, lee@...nel.org,
 ukleinek@...nel.org, broonie@...nel.org, gregkh@...uxfoundation.org,
 linux-input@...r.kernel.org, devicetree@...r.kernel.org,
 linux-pwm@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-usb@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v2 9/9] dt-bindings: mfd: twl: Add missing sub-nodes for
 TWL4030 & TWL603x

Am Thu, 14 Aug 2025 15:21:29 +0200
schrieb Jihed Chaibi <jihed.chaibi.dev@...il.com>:

> Update the TI TWL family Device Tree binding to include additional
> subnodes for TWL4030, TWL6030, and TWL6032 devices.
> 
> This patch enhances the schema by adding support for audio, GPIO, power,
> keypad, PWM, PWM LED, and USB subnodes, referencing their respective YAML
> schemas where applicable. These additions improve the schema's
> completeness, enabling better validation and documentation of the
> TWL multi-function device's capabilities.
> 
> The changes ensure proper handling of TWL4030-specific features (audio,
> keypad, PWM, PWM LED, USB, GPIO, and power) and TWL6030/TWL6032-specific
> features (PWM, PWM LED, and USB), with appropriate schema references to
> prevent unevaluated properties.
> 
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>
> ---
>  .../devicetree/bindings/mfd/ti,twl.yaml       | 63 +++++++++++++++++++
>  1 file changed, 63 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> index f162ab60c..81f9d8f72 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> @@ -76,6 +76,38 @@ allOf:
>            properties:
>              compatible:
>                const: ti,twl4030-wdt
> +
> +        audio:
> +          type: object
> +          $ref: /schemas/sound/ti,twl4030-audio.yaml#
> +          unevaluatedProperties: false
> +
> +        keypad:
> +          type: object
> +          $ref: /schemas/input/ti,twl4030-keypad.yaml#
> +          unevaluatedProperties: false
> +
> +        pwm:
> +          type: object
> +          $ref: /schemas/pwm/ti,twl-pwm.yaml#
> +          unevaluatedProperties: false
> +
> +        pwmled:
> +          type: object
> +          $ref: /schemas/pwm/ti,twl-pwmled.yaml#
> +          unevaluatedProperties: false
> +
I think the pwm stuff is so simple, that it can go in here directly.

> +        'twl4030-usb':
> +          type: object
> +          $ref: /schemas/usb/ti,twlxxxx-usb.yaml#
> +          unevaluatedProperties: false
> +
> +        gpio:
> +          type: object
> +
$ref it to restrict compatibles.

> +        power:
> +          type: object
> +
just list the compatibles allowed here.


Regards,
Andreas