linux-kernel - Re: [PATCH v2 3/9] input: dt-bindings: ti,twl4030-keypad: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ziwtdg4elih73nkguilamjh4gfgg76t2evwvnj6pscywvfexyc@abvlmgoij3us>
Date: Thu, 14 Aug 2025 11:35:53 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Jihed Chaibi <jihed.chaibi.dev@...il.com>
Cc: linux-kernel@...r.kernel.org, andreas@...nade.info, 
	peter.ujfalusi@...il.com, robh@...nel.org, krzk+dt@...nel.org, lgirdwood@...il.com, 
	tiwai@...e.com, conor+dt@...nel.org, lee@...nel.org, ukleinek@...nel.org, 
	broonie@...nel.org, gregkh@...uxfoundation.org, linux-input@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-pwm@...r.kernel.org, linux-sound@...r.kernel.org, 
	linux-usb@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH v2 3/9] input: dt-bindings: ti,twl4030-keypad: convert to
 DT schema

On Thu, Aug 14, 2025 at 03:21:23PM +0200, Jihed Chaibi wrote:
> Convert the legacy TXT binding for the TWL4030 keypad module
> to the modern YAML DT schema format. This adds formal validation
> and improves documentation by inheriting from the matrix-keymap schema.
> 
> Changes in v2:
> Simplified the description field by removing redundant '|'
> as it does not affect formatting in this context.
> 
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>
> ---
>  .../bindings/input/ti,twl4030-keypad.yaml     | 44 +++++++++++++++++++
>  .../bindings/input/twl4030-keypad.txt         | 27 ------------
>  2 files changed, 44 insertions(+), 27 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/input/ti,twl4030-keypad.yaml
>  delete mode 100644 Documentation/devicetree/bindings/input/twl4030-keypad.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/ti,twl4030-keypad.yaml b/Documentation/devicetree/bindings/input/ti,twl4030-keypad.yaml
> new file mode 100644
> index 000000000..2efc88b89
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/ti,twl4030-keypad.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/ti,twl4030-keypad.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TWL4030-family Keypad Controller
> +
> +maintainers:
> +  - Peter Ujfalusi <peter.ujfalusi@...il.com>
> +
> +description:
> +  TWL4030's Keypad controller is used to interface a SoC with a matrix-type
> +  keypad device. The keypad controller supports multiple row and column lines.
> +  A key can be placed at each intersection of a unique row and a unique column.
> +  The keypad controller can sense a key-press and key-release and report the
> +  event using a interrupt to the cpu.
> +
> +allOf:
> +  - $ref: matrix-keymap.yaml#
> +
> +properties:
> +  compatible:
> +    const: ti,twl4030-keypad
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - interrupts
> +  - keypad,num-rows
> +  - keypad,num-columns

I wonder if "linux,keymap" should not be made required as well... 

Thanks.

-- 
Dmitry