linux-kernel - Re: [PATCH v7 02/13] PCI: cadence: Split PCIe controller header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814211657.GA349149@bhelgaas>
Date: Thu, 14 Aug 2025 16:16:57 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: hans.zhang@...tech.com
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
	mani@...nel.org, robh@...nel.org, kwilczynski@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, mpillai@...ence.com,
	fugang.duan@...tech.com, guoyin.chen@...tech.com,
	peter.chen@...tech.com, cix-kernel-upstream@...tech.com,
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 02/13] PCI: cadence: Split PCIe controller header file

On Wed, Aug 13, 2025 at 12:23:20PM +0800, hans.zhang@...tech.com wrote:
> From: Manikandan K Pillai <mpillai@...ence.com>
> 
> Split the Cadence PCIe header file by moving the Legacy(LGA)
> controller register definitions to a separate header file for
> support of next generation PCIe controller architecture.

s/Legacy(LGA)/Legacy (LGA)/

Similar for "HPA(High Performance architecture)" elsewhere.

> +++ b/drivers/pci/controller/cadence/pcie-cadence-lga-regs.h
> @@ -0,0 +1,228 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +// Copyright (c) 2017 Cadence
> +// Cadence PCIe controller driver.
> +// Author: Manikandan K Pillai <mpillai@...ence.com>

I'm not trying to be a killjoy, but the only author listed in
pcie-cadence.h is Cyrille Pitchen, and I don't think simply moving
these definitions to a separate file really counts as becoming the
author.  I would at least preserve Cyrille's authorship.

Bjorn