linux-kernel - Re: [PATCH v7 01/13] PCI: cadence: Add support for modules for cadence controller builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814212553.GA349461@bhelgaas>
Date: Thu, 14 Aug 2025 16:25:53 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: hans.zhang@...tech.com
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
	mani@...nel.org, robh@...nel.org, kwilczynski@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, mpillai@...ence.com,
	fugang.duan@...tech.com, guoyin.chen@...tech.com,
	peter.chen@...tech.com, cix-kernel-upstream@...tech.com,
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 01/13] PCI: cadence: Add support for modules for
 cadence controller builds

No need to repeat "cadence" in the subject.  Something like this would
be sufficient:

  PCI: cadence: Add module support for platform controller driver

On Wed, Aug 13, 2025 at 12:23:19PM +0800, hans.zhang@...tech.com wrote:
> From: Manikandan K Pillai <mpillai@...ence.com>
> 
> Add support for building PCI cadence platforms as a module.
> 
> Signed-off-by: Manikandan K Pillai <mpillai@...ence.com>
> Signed-off-by: Hans Zhang <hans.zhang@...tech.com>

> +++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c
> @@ -178,3 +178,7 @@ static struct platform_driver cdns_plat_pcie_driver = {
>  	.shutdown = cdns_plat_pcie_shutdown,
>  };
>  builtin_platform_driver(cdns_plat_pcie_driver);

Do you need any change here, e.g., to module_platform_driver()?  I'm
not an expert in the module machinery, so just a question.

> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Cadence PCIe controller platform driver");
> +MODULE_AUTHOR("Manikandan K Pillai <mpillai@...ence.com>");
> diff --git a/drivers/pci/controller/cadence/pcie-cadence.c b/drivers/pci/controller/cadence/pcie-cadence.c
> index 70a19573440e..5603f214f4c7 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence.c
> @@ -279,6 +279,7 @@ const struct dev_pm_ops cdns_pcie_pm_ops = {
>  	NOIRQ_SYSTEM_SLEEP_PM_OPS(cdns_pcie_suspend_noirq,
>  				  cdns_pcie_resume_noirq)
>  };
> +EXPORT_SYMBOL_GPL(cdns_pcie_pm_ops);
>  
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("Cadence PCIe controller driver");
> -- 
> 2.49.0
>