linux-kernel - Re: [PATCH v7 04/13] PCI: cadence: Split PCIe EP support into common and specific functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814214154.GA350532@bhelgaas>
Date: Thu, 14 Aug 2025 16:41:54 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: hans.zhang@...tech.com
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
	mani@...nel.org, robh@...nel.org, kwilczynski@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, mpillai@...ence.com,
	fugang.duan@...tech.com, guoyin.chen@...tech.com,
	peter.chen@...tech.com, cix-kernel-upstream@...tech.com,
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 04/13] PCI: cadence: Split PCIe EP support into common
 and specific functions

On Wed, Aug 13, 2025 at 12:23:22PM +0800, hans.zhang@...tech.com wrote:
> From: Manikandan K Pillai <mpillai@...ence.com>
> 
> Split the Cadence PCIe controller EP functionality into common
> ibrary functions and functions for legacy PCIe EP controller.

s/ibrary/library/

> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep-common.c
> @@ -0,0 +1,252 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2017 Cadence
> +// Cadence PCIe endpoint controller driver common
> +// Author: Manikandan K Pillai <mpillai@...ence.com>

This *looks* like mostly a code move from pcie-cadence-ep.c to
pcie-cadence-ep-common.c.  If that's the case, make this patch *only*
a move (no code changes or whitespace changes as in
cdns_pcie_ep_start()).  And say in the commit log that you're only
moving, not changing, the code.

Also preserve the author from pcie-cadence-ep.c if that's the case.

I do look a little sideways at the // comments since the pcie-cadence*
files are basically the only users in drivers/pci/ (except for the
ibmhp driver that is ancient and basically dead).

Bjorn