linux-kernel - Re: [PATCH v7 05/13] PCI: cadence: Split PCIe RP support into common and specific functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250814214843.GA350844@bhelgaas>
Date: Thu, 14 Aug 2025 16:48:43 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: hans.zhang@...tech.com
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
	mani@...nel.org, robh@...nel.org, kwilczynski@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, mpillai@...ence.com,
	fugang.duan@...tech.com, guoyin.chen@...tech.com,
	peter.chen@...tech.com, cix-kernel-upstream@...tech.com,
	linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 05/13] PCI: cadence: Split PCIe RP support into common
 and specific functions

On Wed, Aug 13, 2025 at 12:23:23PM +0800, hans.zhang@...tech.com wrote:
> From: Manikandan K Pillai <mpillai@...ence.com>
> 
> Split the Cadence PCIe controller RP functionality into common
> functions and functions for legacy PCIe RP controller.

I guess this is simply a move, with no actual code changes?

> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep-common.h
> @@ -1,10 +1,10 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  // Copyright (c) 2017 Cadence
> -// Cadence PCIe Endpoint controller driver.
> +// Cadence PCIe Endpoint controller driver
>  // Author: Manikandan K Pillai <mpillai@...ence.com>
>  
> -#ifndef _PCIE_CADENCE_EP_COMMON_H_
> -#define _PCIE_CADENCE_EP_COMMON_H_
> +#ifndef _PCIE_CADENCE_EP_COMMON_H
> +#define _PCIE_CADENCE_EP_COMMON_H
>  
>  #include <linux/kernel.h>
>  #include <linux/pci.h>
> @@ -33,4 +33,4 @@ const struct pci_epc_features *cdns_pcie_ep_get_features(struct pci_epc *epc,
>  							 u8 func_no,
>  							 u8 vfunc_no);
>  
> -#endif /* _PCIE_CADENCE_EP_COMMON_H_ */
> +#endif /* _PCIE_CADENCE_EP_COMMON_H */

All these changes should be in the patch that creates
pcie-cadence-ep-common.h so we don't have to touch it twice.

> diff --git a/drivers/pci/controller/cadence/pcie-cadence-host-common.c b/drivers/pci/controller/cadence/pcie-cadence-host-common.c
> new file mode 100644
> index 000000000000..5625c64c7974
> --- /dev/null
> +++ b/drivers/pci/controller/cadence/pcie-cadence-host-common.c
> @@ -0,0 +1,181 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2017 Cadence
> +// Cadence PCIe host controller driver.
> +// Author: Manikandan K Pillai <mpillai@...ence.com>

Not sure about the author here.  The authorship info is usually all
there in the git history, so there's less value in including it in the
file itself than there used to be.