linux-kernel - Re: [PATCH 2/3] ufs: ufs-qcom: describe x1e80100 quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a22ef70-02ed-4436-8c6d-822d04f2c930@kernel.org>
Date: Thu, 14 Aug 2025 08:59:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Harrison Vanderbyl <harrison.vanderbyl@...il.com>, marcus@...gul.ch,
 kirill@...ins.ky, vkoul@...nel.org, kishon@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, mani@...nel.org,
 alim.akhtar@...sung.com, avri.altman@....com, bvanassche@....org,
 andersson@...nel.org, agross@...nel.org, linux-arm-msm@...r.kernel.org,
 linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 2/3] ufs: ufs-qcom: describe x1e80100 quirks

On 14/08/2025 02:59, Harrison Vanderbyl wrote:
> Describe describe driver quirks for x1e80100 ufs device
> Signed-off-by: Harrison Vanderbyl <harrison.vanderbyl@...il.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3 +++
>  drivers/ufs/host/ufs-qcom.c             | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> index 9c69c77d10c8..b88cafac4da7 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> @@ -2168,6 +2168,9 @@ static const struct of_device_id qmp_ufs_of_match_table[] = {
>  	}, {
>  		.compatible = "qcom,sm8750-qmp-ufs-phy",
>  		.data = &sm8750_ufsphy_cfg,
> +	}, {
> +		.compatible = "qcom,x1e80100-qmp-ufs-phy",
> +		.data = &sm8550_ufsphy_cfg,

So it is fully compatible? If so then don't duplicate entries and
express compatibility with fallback.

>  	},
>  
>  	{ },
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 76fc70503a62..2e143ccd1a03 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -2282,6 +2282,7 @@ static const struct of_device_id ufs_qcom_of_match[] __maybe_unused = {
>  	{ .compatible = "qcom,ufshc" },
>  	{ .compatible = "qcom,sm8550-ufshc", .data = &ufs_qcom_sm8550_drvdata },
>  	{ .compatible = "qcom,sm8650-ufshc", .data = &ufs_qcom_sm8550_drvdata },
> +	{ .compatible = "qcom,x1e80100-ufshc", .data = &ufs_qcom_sm8550_drvdata },

Same problem here.


Best regards,
Krzysztof