linux-kernel - Re: [PATCH v1] cpufreq: Return current frequency when frequency table is unavailable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f901678-c75e-48ac-985a-2834f9ba4c8f@kylinos.cn>
Date: Thu, 14 Aug 2025 17:24:38 +0800
From: Zihuan Zhang <zhangzihuan@...inos.cn>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: "rafael J . wysocki" <rafael@...nel.org>,
 zhenglifeng <zhenglifeng1@...wei.com>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] cpufreq: Return current frequency when frequency table
 is unavailable

在 2025/8/14 17:02, Viresh Kumar 写道:
> On 14-08-25, 16:52, Zihuan Zhang wrote:
>> In cases where the CPU frequency table (freq_table) is not available,
>> the __resolve_freq() function will now return the current frequency
>> (policy->cur) instead of the requested target frequency. This ensures
>> that the system doesn't return an invalid or uninitialized frequency
>> value when frequency scaling is not supported or not initialized.
>>
>> This change improves the stability of the frequency scaling logic when
>> the CPU frequency table is not populated, preventing errors related
>> to unavailable frequency tables.
> Is there a real problem you are facing ? Or a code that path can do
> some harm ? I think this patch may end up breaking users.

Haven’t yet.

I just feel that it might not be ideal to set a frequency when the 
frequency table is unavailable.

Perhaps adding a log or warning when the frequency table is missing 
could be a better approach.