linux-kernel - Re: [PATCH v6 0/9] clk: bcm: kona: Add bus clock support, bus clocks for BCM21664/BCM281xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175526317070.1748815.1341247491221597696.robh@kernel.org>
Date: Fri, 15 Aug 2025 08:08:36 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Artur Weber <aweber.kernel@...il.com>
Cc: Michael Turquette <mturquette@...libre.com>, 
 Alex Elder <elder@...cstar.com>, Stephen Boyd <sboyd@...nel.org>, 
 Stanislav Jakubek <stano.jakubek@...il.com>, 
 Florian Fainelli <florian.fainelli@...adcom.com>, 
 Alex Elder <elder@...nel.org>, ~postmarketos/upstreaming@...ts.sr.ht, 
 Scott Branden <sbranden@...adcom.com>, 
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
 linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 Ray Jui <rjui@...adcom.com>, Conor Dooley <conor+dt@...nel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org, 
 devicetree@...r.kernel.org
Subject: Re: [PATCH v6 0/9] clk: bcm: kona: Add bus clock support, bus
 clocks for BCM21664/BCM281xx


On Wed, 13 Aug 2025 13:00:06 +0200, Artur Weber wrote:
> This patchset does the following:
> 
> - Introduce support for bus clocks. These are fairly similar to
>   peripheral clocks, but only implement policy, gate and hyst.
> 
> - Add matching bus clocks for BCM21664 and BCM281xx peripheral clocks
>   and update device tree bindings to match.
> 
> Signed-off-by: Artur Weber <aweber.kernel@...il.com>
> ---
> Changes in v6:
> - Rebase on v6.16
> - Make kona_bus_clk_ops const, add a new commit to make kona_peri_clk_ops const as well
> - Link to v5: https://lore.kernel.org/r/20250430-kona-bus-clock-v5-0-46766b28b93a@gmail.com/
> 
> Changes in v5:
> - Pick up Reviewed-by trailer from Krzysztof on patch 3
> - Rebase on v6.14
> - No code changes since v4
> - Link to v4: https://lore.kernel.org/r/20250318-kona-bus-clock-v4-0-f54416e8328f@gmail.com
> 
> Changes in v4:
> - Rename moved CLOCK_COUNT defines to CLK_COUNT to avoid redefinition
> - Squash BCM21664/BCM281xx bus clock DT bindings commits together
> - Link to v3: https://lore.kernel.org/r/20250308-kona-bus-clock-v3-0-d6fb5bfc3b67@gmail.com
> 
> Changes in v3:
> - Fix DT schema example in BCM281xx bus clock bindings
> - Move CLOCK_COUNT defines from dt-bindings header to the driver
> - Fix BCM21664 UARTBx_APB IDs being out of order compared to clock
>   driver
> - Link to v2: https://lore.kernel.org/r/20250303-kona-bus-clock-v2-0-a363c6a6b798@gmail.com
> 
> Changes in v2:
> - Drop prerequisite clock patch
> - Move clock/bcm21664.h dt-bindings header change to dt-bindings patch
> - Add BCM281xx bus clocks
> - Link to v1: https://lore.kernel.org/r/20250216-kona-bus-clock-v1-0-e8779d77a6f2@gmail.com
> 
> ---
> Artur Weber (9):
>       clk: bcm: kona: Move CLOCK_COUNT defines into the driver
>       dt-bindings: clock: brcm,kona-ccu: Drop CLOCK_COUNT defines from DT headers
>       dt-bindings: clock: brcm,kona-ccu: Add BCM21664 and BCM281xx bus clocks
>       clk: bcm: kona: Make kona_peri_clk_ops const
>       clk: bcm: kona: Add support for bus clocks
>       clk: bcm21664: Add corresponding bus clocks for peripheral clocks
>       clk: bcm281xx: Add corresponding bus clocks for peripheral clocks
>       ARM: dts: bcm2166x-common: Add matching bus clocks for peripheral clocks
>       ARM: dts: bcm11351: Add corresponding bus clocks for peripheral clocks
> 
>  .../devicetree/bindings/clock/brcm,kona-ccu.yaml   |  49 ++++++-
>  arch/arm/boot/dts/broadcom/bcm11351.dtsi           |  33 +++--
>  arch/arm/boot/dts/broadcom/bcm2166x-common.dtsi    |  28 ++--
>  drivers/clk/bcm/clk-bcm21664.c                     |  99 ++++++++++++++-
>  drivers/clk/bcm/clk-bcm281xx.c                     | 141 ++++++++++++++++++++-
>  drivers/clk/bcm/clk-kona-setup.c                   | 116 +++++++++++++++++
>  drivers/clk/bcm/clk-kona.c                         |  64 +++++++++-
>  drivers/clk/bcm/clk-kona.h                         |  14 +-
>  include/dt-bindings/clock/bcm21664.h               |  17 ++-
>  include/dt-bindings/clock/bcm281xx.h               |  24 +++-
>  10 files changed, 540 insertions(+), 45 deletions(-)
> ---
> base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
> change-id: 20250212-kona-bus-clock-4297eefae940
> 
> Best regards,
> --
> Artur Weber <aweber.kernel@...il.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 038d61fd642278bab63ee8ef722c50d10ab01e8f

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/broadcom/' for 20250813-kona-bus-clock-v6-0-f5a63d4920a4@...il.com:

arch/arm/boot/dts/broadcom/bcm94709.dtb: /axi@...00000: failed to match any schema with compatible: ['brcm,bus-axi']