[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250816110458.470ea150@jic23-huawei>
Date: Sat, 16 Aug 2025 11:04:58 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Ben Collins <bcollins@...ter.com>
Cc: David Lechner <dlechner@...libre.com>, Nuno Sá
<nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] iio: mcp9600: Recognize chip id for mcp9601
On Fri, 15 Aug 2025 16:46:05 +0000
Ben Collins <bcollins@...ter.com> wrote:
> The current driver works with mcp9601, but emits a warning because it
> does not recognize the chip id.
>
> MCP9601 is a superset of MCP9600. The drivers works without changes
> on this chipset.
>
> However, the 9601 chip supports open/closed-circuit detection if wired
> properly, so we'll need to be able to differentiate between them.
>
> Signed-off-by: Ben Collins <bcollins@...ter.com>
> ---
> drivers/iio/temperature/Kconfig | 8 +++--
> drivers/iio/temperature/mcp9600.c | 51 +++++++++++++++++++++++++------
> 2 files changed, 46 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/iio/temperature/Kconfig b/drivers/iio/temperature/Kconfig
> index 1244d8e17d504..e14ea6ebc7a24 100644
> --- a/drivers/iio/temperature/Kconfig
> +++ b/drivers/iio/temperature/Kconfig
> @@ -173,11 +173,13 @@ config MAX31865
> will be called max31865.
>
> config MCP9600
> - tristate "MCP9600 thermocouple EMF converter"
> + tristate "MCP9600 and similar thermocouple EMF converters"
> depends on I2C
> help
> - If you say yes here you get support for MCP9600
> - thermocouple EMF converter connected via I2C.
> + If you say yes here you get support for:
> + - MCP9600
> + - MCP9601
> + and similar thermocouple EMF converters connected via I2C.
If we are updating this list every time, do we need to add the 'and similar'
to the help text? It makes sense only in the short description above where
we aren't listing them.
>
> This driver can also be built as a module. If so, the module
> will be called mcp9600.
>
Powered by blists - more mailing lists