linux-kernel - [PATCH 00/14] scsi: scsi_error: Introduce new error handle mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250817084633.1409286-1-jiangjianjun3@huawei.com>
Date: Sun, 17 Aug 2025 16:46:33 +0800
From: JiangJianJun <jiangjianjun3@...wei.com>
To: <James.Bottomley@...senPartnership.com>, <martin.petersen@...cle.com>,
	<linux-scsi@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, <hare@...e.de>, <bvanassche@....org>,
	<michael.christie@...cle.com>, <hch@...radead.org>, <haowenchao22@...il.com>,
	<john.g.garry@...cle.com>, <hewenliang4@...wei.com>, <yangyun50@...wei.com>,
	<wuyifeng10@...wei.com>, <wubo40@...wei.com>, <yangxingui@...artners.com>
Subject: [PATCH 00/14] scsi: scsi_error: Introduce new error handle mechanism

I apologize for taking too long to test and modify these patches.Here
are the revision points, with the first two being the main ones:
  1. The scsi_target.can_queue value can control the increment and
    decrement operations of scsi_target.target_busy. The new error
    handler also needs to adjust target_busy. Both Bart and Mike opposed
    removing this control condition. In this version, I have only added
    the error handler check when scsi_target.can_queue <= 0.
    link: https://lore.kernel.org/linux-scsi/daba5c92-2395-4eee-b212-978fbe83b56f@oracle.com/
  2. I have added callbacks for setting and clearing the error handler
    in scsi_host_template. Drivers can support device or target error
    handlers by setting these callbacks. I believe the advantage of this
    approach is that driver developers will be aware of this feature
    when they see the callback prototypes and comments, and it can be
    used even without device or target initialization callbacks.
    However, this means that the modparam controlling the enablement can
    only be removed. I have considered adding configurations only for
    the virtio_scsi and iscsi_tcp drivers. 
    link: https://lore.kernel.org/linux-scsi/b8350de1-6ac8-4d5f-aaa7-7b03e2f7aa93@oracle.com/
  3. In scsi_eh_scmd_add, a return statement was added under the
    condition of xxx_in_recovery because each branch ultimately calls
    scsi_eh_scmd_add_shost, which does not fail. Therefore, continuing
    further would result in duplicate additions.
  4. The return type of ->is_busy was changed to bool. 

I have retained the original content of Wenchao's email in cover letter.