linux-kernel - Re: [PATCH 08/14] scsi: scsi_error: Add a general LUN based error handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <039c1b2d-a241-47d9-bb3b-b0d3a822d69f@web.de>
Date: Sun, 17 Aug 2025 11:18:08 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: JiangJianJun <jiangjianjun3@...artners.com>,
 Wenchao Hao <haowenchao2@...wei.com>, linux-scsi@...r.kernel.org,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Bart Van Assche
 <bvanassche@....org>, Bo Wu <wubo40@...wei.com>,
 Christoph Hellwig <hch@...radead.org>, Hannes Reinecke <hare@...e.de>,
 hewenliang4@...wei.com, John Garry <john.g.garry@...cle.com>,
 Mike Christie <michael.christie@...cle.com>,
 Wenchao Hao <haowenchao22@...il.com>, wuyifeng10@...wei.com,
 yangxingui@...artners.com, yangyun50@...wei.com
Subject: Re: [PATCH 08/14] scsi: scsi_error: Add a general LUN based error
 handler

…
> +++ b/drivers/scsi/scsi_error.c
> @@ -2804,3 +2804,182 @@ bool scsi_get_sense_info_fld(const u8 *sense_buffer, int sb_len,
…
> +static void sdev_eh_add_cmnd(struct scsi_cmnd *scmd)
> +{
…
> +	spin_lock_irqsave(&luneh->eh_lock, flags);
> +	list_add_tail(&scmd->eh_entry, &luneh->eh_cmd_q);
> +	luneh->eh_num++;
> +	spin_unlock_irqrestore(&luneh->eh_lock, flags);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&luneh->eh_lock);”?
https://elixir.bootlin.com/linux/v6.17-rc1/source/include/linux/spinlock.h#L585-L588

Regards,
Markus