linux-kernel - Re: [PATCH 5/5] LoongArch: KVM: Add address alignment check in pch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H6rQVVF_Z+5A7AR+5Q-A2ydw4sxc9Qq6+-r33kRwYjwAA@mail.gmail.com>
Date: Sun, 17 Aug 2025 11:45:46 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Bibo Mao <maobibo@...ngson.cn>
Cc: Tianrui Zhao <zhaotianrui@...ngson.cn>, Xianglai Li <lixianglai@...ngson.cn>, kvm@...r.kernel.org, 
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] LoongArch: KVM: Add address alignment check in
 pch_pic register access

This one is applied for loongarch-fixes.

Huacai

On Mon, Aug 11, 2025 at 10:15 AM Bibo Mao <maobibo@...ngson.cn> wrote:
>
> With pch_pic device, its register is based on MMIO address space,
> different access size 1/2/4/8 is supported. And base address should
> be naturally aligned with its access size, here add alignment check
> in its register access emulation function.
>
> Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
> ---
>  arch/loongarch/kvm/intc/pch_pic.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/loongarch/kvm/intc/pch_pic.c b/arch/loongarch/kvm/intc/pch_pic.c
> index 0710b5ab286e..5ee24dbf3c4c 100644
> --- a/arch/loongarch/kvm/intc/pch_pic.c
> +++ b/arch/loongarch/kvm/intc/pch_pic.c
> @@ -151,6 +151,11 @@ static int kvm_pch_pic_read(struct kvm_vcpu *vcpu,
>                 return -EINVAL;
>         }
>
> +       if (addr & (len - 1)) {
> +               kvm_err("%s: pch pic not aligned addr %llx len %d\n", __func__, addr, len);
> +               return -EINVAL;
> +       }
> +
>         /* statistics of pch pic reading */
>         vcpu->stat.pch_pic_read_exits++;
>         ret = loongarch_pch_pic_read(s, addr, len, val);
> @@ -246,6 +251,11 @@ static int kvm_pch_pic_write(struct kvm_vcpu *vcpu,
>                 return -EINVAL;
>         }
>
> +       if (addr & (len - 1)) {
> +               kvm_err("%s: pch pic not aligned addr %llx len %d\n", __func__, addr, len);
> +               return -EINVAL;
> +       }
> +
>         /* statistics of pch pic writing */
>         vcpu->stat.pch_pic_write_exits++;
>         ret = loongarch_pch_pic_write(s, addr, len, val);
> --
> 2.39.3
>
>