linux-kernel - Re: [PATCH v4 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <fb4d74b9-a92a-4040-8d3a-09c72db3f35a@redhat.com>
Date: Sun, 17 Aug 2025 10:07:01 +0200
From: David Hildenbrand <david@...hat.com>
To: Giant Sand Fans <rampxxxx@...il.com>, Wei Yang <richard.weiyang@...il.com>
Cc: Aboorva Devarajan <aboorvad@...ux.ibm.com>,
 "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
 "Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>,
 "lorenzo.stoakes@...cle.com" <lorenzo.stoakes@...cle.com>,
 "shuah@...nel.org" <shuah@...nel.org>, "pfalcato@...e.de"
 <pfalcato@...e.de>, "ziy@...dia.com" <ziy@...dia.com>,
 "baolin.wang@...ux.alibaba.com" <baolin.wang@...ux.alibaba.com>,
 "npache@...hat.com" <npache@...hat.com>,
 "ryan.roberts@....com" <ryan.roberts@....com>,
 "dev.jain@....com" <dev.jain@....com>, "baohua@...nel.org"
 <baohua@...nel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
 "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "donettom@...ux.ibm.com" <donettom@...ux.ibm.com>,
 "ritesh.list@...il.com" <ritesh.list@...il.com>
Subject: Re: [PATCH v4 4/7] mm/selftests: Fix split_huge_page_test failure on
 systems with 64KB page size


>  >>diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/ 
> tools/testing/selftests/mm/split_huge_page_test.c
>  >>index eadbeb820d71..7cbeaebc9d71 100644
>  >>--- a/tools/testing/selftests/mm/split_huge_page_test.c
>  >>+++ b/tools/testing/selftests/mm/split_huge_page_test.c
>  >>@@ -523,6 +523,9 @@ int main(int argc, char **argv)
>  >>       const char *fs_loc;
>  >>       bool created_tmp;
>  >>       int offset;
>  >>+      unsigned int max_order;
>  >>+      unsigned int nr_pages;
>  >>+      unsigned int tests;
>  >>
>  >>       ksft_print_header();
>  >>
>  >>@@ -534,35 +537,38 @@ int main(int argc, char **argv)
>  >>       if (argc > 1)
>  >>               optional_xfs_path = argv[1];
>  >>
>  >>-      ksft_set_plan(1+8+1+9+9+8*4+2);
>  >>-
>  >>       pagesize = getpagesize();
>  >>       pageshift = ffs(pagesize) - 1;
>  >>       pmd_pagesize = read_pmd_pagesize();
>  >>       if (!pmd_pagesize)
>  >>               ksft_exit_fail_msg("Reading PMD pagesize failed\n");
>  >>
>  >>+      nr_pages = pmd_pagesize / pagesize;
>  >>+      max_order =  sz2ord(pmd_pagesize);
>  >                     ^
>  >                     extra space here
>  >
>  >>+      tests = 2 + (max_order - 1) + (2 * max_order) + (max_order - 
> 1) * 4 + 2;
> 
> Is it possible to have some defines here instead plain numbers?
> Thanks

I assume we should look into using kselftest_harness as a separate 
effort, so we can avoid this manual test calculation completely. I'm 
afraid even using defines will not make this significntly more readable.

-- 
Cheers

David / dhildenb