linux-kernel - Re: [PATCH v2 18/24] media: iris: Add support for G/S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48318ea6-4a61-303e-7b78-0f499fef8b61@quicinc.com>
Date: Mon, 18 Aug 2025 13:04:33 +0530
From: Vikash Garodia <quic_vgarodia@...cinc.com>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>,
        Abhinav Kumar
	<abhinav.kumar@...ux.dev>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil
	<hverkuil@...all.nl>,
        Stefan Schmidt <stefan.schmidt@...aro.org>,
        "Vedang
 Nagar" <quic_vnagar@...cinc.com>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Renjiang Han <quic_renjiang@...cinc.com>,
        Wangao Wang <quic_wangaow@...cinc.com>
Subject: Re: [PATCH v2 18/24] media: iris: Add support for G/S_PARM for
 encoder video device


On 8/18/2025 12:59 PM, Dikshita Agarwal wrote:
>>> diff --git a/drivers/media/platform/qcom/iris/iris_venc.c b/drivers/media/platform/qcom/iris/iris_venc.c
>>> index 930f5afe9489d01be193f1dbe429d33f5401b468..11666f40a4d1c34e1b6eca0b5e40e0f09eeb2b67 100644
>>> --- a/drivers/media/platform/qcom/iris/iris_venc.c
>>> +++ b/drivers/media/platform/qcom/iris/iris_venc.c
>>> @@ -58,6 +58,9 @@ int iris_venc_inst_init(struct iris_inst *inst)
>>>  	inst->crop.width = f->fmt.pix_mp.width;
>>>  	inst->crop.height = f->fmt.pix_mp.height;
>>>  
>>> +	inst->operating_rate = DEFAULT_FPS << 16;
>>> +	inst->frame_rate = DEFAULT_FPS << 16;
>> I understand that firmware expects the rate in Q16 format, but does driver needs
>> to keep it in that format ? I see most of the time in calculations, it is right
>> shifted to bring it back to normal one and then back n forth.
>>
> Currently in driver inst->frame_rate is in Q16 format everywhere, no
> inconsistency.
> 
> do you prefer to keep it in non Q16 format and convert to Q16 when setting
> to firmware?
> 
Given that it simplifies the handling in driver, by avoiding doing the
adjustment everytime before using that value, yes please.

Regards,
Vikash