linux-kernel - Re: [PATCH v2 04/24] media: iris: Fix port streaming handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b9d5f6e-ee95-e4d1-3fac-fdcb277a7af3@quicinc.com>
Date: Mon, 18 Aug 2025 15:15:13 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Vikash Garodia
	<quic_vgarodia@...cinc.com>,
        Abhinav Kumar <abhinav.kumar@...ux.dev>,
        "Mauro
 Carvalho Chehab" <mchehab@...nel.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        Stefan Schmidt <stefan.schmidt@...aro.org>,
        Vedang Nagar
	<quic_vnagar@...cinc.com>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Renjiang Han <quic_renjiang@...cinc.com>,
        Wangao Wang <quic_wangaow@...cinc.com>
Subject: Re: [PATCH v2 04/24] media: iris: Fix port streaming handling



On 8/16/2025 4:10 PM, Bryan O'Donoghue wrote:
> On 13/08/2025 10:37, Dikshita Agarwal wrote:
>> +    if (!ret)
> 
> I think you should have a consistent error pattern
> 
> if (ret)
>     goto error;
> 
Its done to avoid duplication of code, otherwise it would look like

if (inst->state == IRIS_INST_STREAMING)
	ret = iris_queue_internal_deferred_buffers(inst, BUF_DPB);
	if (ret)
		goto error;
	
	ret = iris_queue_deferred_buffers(inst, buf_type);
	if (ret)
		goto error;

and more duplication when encoder is added.

Thanks,
Dikshita
> Once amended
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> 
> ---
> bod