linux-kernel - Re: [PATCH] lib/vsprintf: remove redundant header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nNnz5esQpGFsENUm4cgGOAkkkqCuHyNxfEPHUrFvaH8g@mail.gmail.com>
Date: Tue, 19 Aug 2025 15:37:20 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Liao Yuanhong <liaoyuanhong@...o.com>, Stephen Rothwell <sfr@...b.auug.org.au>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Petr Mladek <pmladek@...e.com>, Harry Yoo <harry.yoo@...cle.com>, Kees Cook <kees@...nel.org>, 
	Sergio Perez Gonzalez <sperezglz@...il.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib/vsprintf: remove redundant header files

On Tue, Aug 19, 2025 at 3:13 PM Liao Yuanhong <liaoyuanhong@...o.com> wrote:
>
> The header file <linux/stdarg.h> is already included on line 6. Remove the
> redundant include.
>
> Fixes: 0dec7201788b9 ("sprintf.h requires stdarg.h")

I don't think this fixes that commit -- `stdarg.h` was not there back then.

Instead, this commit

    be06b53d3af0 ("lib/vsprintf: include stdarg.h from sprintf.h to
provide va_list")

also added the line, and I assume Stephen only needs to drop one of
the lines in this merge resolution next time:

    3f413b9a3770 ("Merge branch 'next' of
https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git")

Thanks!

Cheers,
Miguel