linux-kernel - Re: [PATCH] lib/vsprintf: remove redundant header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <893eb958-68f9-44f7-a1dc-4869af87c7c1@vivo.com>
Date: Tue, 19 Aug 2025 22:18:29 +0800
From: Liao Yuanhong <liaoyuanhong@...o.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Petr Mladek <pmladek@...e.com>, Harry Yoo <harry.yoo@...cle.com>,
 Kees Cook <kees@...nel.org>, Sergio Perez Gonzalez <sperezglz@...il.com>,
 Miguel Ojeda <ojeda@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 open list <linux-kernel@...r.kernel.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH] lib/vsprintf: remove redundant header files


On 8/19/2025 9:37 PM, Miguel Ojeda wrote:
> [You don't often get email from miguel.ojeda.sandonis@...il.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Tue, Aug 19, 2025 at 3:13 PM Liao Yuanhong <liaoyuanhong@...o.com> wrote:
>> The header file <linux/stdarg.h> is already included on line 6. Remove the
>> redundant include.
>>
>> Fixes: 0dec7201788b9 ("sprintf.h requires stdarg.h")
> I don't think this fixes that commit -- `stdarg.h` was not there back then.
>
> Instead, this commit
>
>      be06b53d3af0 ("lib/vsprintf: include stdarg.h from sprintf.h to
> provide va_list")
>
> also added the line, and I assume Stephen only needs to drop one of
> the lines in this merge resolution next time:
>
>      3f413b9a3770 ("Merge branch 'next' of
> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git")
>
> Thanks!
>
> Cheers,
> Miguel

Thank you for your feedback. Do I need to submit the v2 version without 
fixes？


Regards,

Liao