linux-kernel - Re: [PATCH] usb: typec: mux: Remove the use of dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6186026.lOV4Wx5bFT@fw-rgant>
Date: Tue, 19 Aug 2025 16:46:39 +0200
From: Romain Gantois <romain.gantois@...tlin.com>
To: heikki.krogerus@...ux.intel.com, gregkh@...uxfoundation.org,
 Xichao Zhao <zhao.xichao@...o.com>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
 Xichao Zhao <zhao.xichao@...o.com>
Subject: Re: [PATCH] usb: typec: mux: Remove the use of dev_err_probe()

On Tuesday, 19 August 2025 13:24:51 CEST Xichao Zhao wrote:
> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> Therefore, remove the useless call to dev_err_probe(), and just
> return the value instead.
> 
> Signed-off-by: Xichao Zhao <zhao.xichao@...o.com>
> ---
>  drivers/usb/typec/mux/tusb1046.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/mux/tusb1046.c
> b/drivers/usb/typec/mux/tusb1046.c index b4f45c217b59..3c1a4551c2fb 100644
> --- a/drivers/usb/typec/mux/tusb1046.c
> +++ b/drivers/usb/typec/mux/tusb1046.c
> @@ -129,7 +129,7 @@ static int tusb1046_i2c_probe(struct i2c_client *client)
> 
>  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>  	if (!priv)
> -		return dev_err_probe(dev, -ENOMEM, "failed to allocate driver 
data\n");
> +		return -ENOMEM;
> 
>  	priv->client = client;

Reviewed-by: Romain Gantois <romain.gantois@...tlin.com>



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)