[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <phbil4fflttlcp7s4nxyceyb2a277eablveozggloufowwzplu@c4a2mrtnfunf>
Date: Tue, 19 Aug 2025 21:35:55 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
Cc: Georgi Djakov <djakov@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Mike Tipton <mike.tipton@....qualcomm.com>,
linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Odelu Kukatla <odelu.kukatla@....qualcomm.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: interconnect: document the RPMh
Network-On-Chip interconnect in Glymur SoC
On Thu, Aug 14, 2025 at 02:54:19PM +0000, Raviteja Laggyshetty wrote:
> Document the RPMh Network-On-Chip Interconnect in Glymur platform.
>
> Co-developed-by: Odelu Kukatla <odelu.kukatla@....qualcomm.com>
> Signed-off-by: Odelu Kukatla <odelu.kukatla@....qualcomm.com>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
> ---
> .../bindings/interconnect/qcom,glymur-rpmh.yaml | 172 +++++++++++++++++
> .../dt-bindings/interconnect/qcom,glymur-rpmh.h | 205 +++++++++++++++++++++
> 2 files changed, 377 insertions(+)
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,glymur-gcc.h>
Please drop this header and use ephemeral clocks in the devices below.
We don't need to point out particular GCC clocks, using
<&gcc_foo_bar_baz> is more than enough.
> + clk_virt: interconnect-0 {
> + compatible = "qcom,glymur-clk-virt";
> + #interconnect-cells = <2>;
> + qcom,bcm-voters = <&apps_bcm_voter>;
> + };
> +
> + aggre1_noc: interconnect@...0000 {
> + compatible = "qcom,glymur-aggre1-noc";
> + reg = <0x016e0000 0x14400>;
> + #interconnect-cells = <2>;
> + qcom,bcm-voters = <&apps_bcm_voter>;
> + };
> +
> + aggre4_noc: interconnect@...0000 {
> + compatible = "qcom,glymur-aggre4-noc";
> + reg = <0x01740000 0x14400>;
> + #interconnect-cells = <2>;
> + qcom,bcm-voters = <&apps_bcm_voter>;
> + clocks = <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>,
> + <&gcc GCC_AGGRE_USB3_SEC_AXI_CLK>,
> + <&gcc GCC_AGGRE_USB4_0_AXI_CLK>,
> + <&gcc GCC_AGGRE_USB4_1_AXI_CLK>;
> + };
--
With best wishes
Dmitry
Powered by blists - more mailing lists