linux-kernel - Re: [PATCH v2 1/3] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in Glymur SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36974682-c8f1-4bcd-91f3-255c6332c0fe@kernel.org>
Date: Tue, 19 Aug 2025 21:02:57 +0300
From: Georgi Djakov <djakov@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
 Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Mike Tipton <mike.tipton@....qualcomm.com>, linux-arm-msm@...r.kernel.org,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Odelu Kukatla <odelu.kukatla@....qualcomm.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: interconnect: document the RPMh
 Network-On-Chip interconnect in Glymur SoC

On 8/19/25 7:03 PM, Krzysztof Kozlowski wrote:
> On 19/08/2025 15:46, Georgi Djakov wrote:
>> On 8/19/25 4:31 PM, Rob Herring wrote:
>>> On Thu, Aug 14, 2025 at 9:54 AM Raviteja Laggyshetty
>>> <raviteja.laggyshetty@....qualcomm.com> wrote:
>>>>
>>>> Document the RPMh Network-On-Chip Interconnect in Glymur platform.
>>>>
>>>> Co-developed-by: Odelu Kukatla <odelu.kukatla@....qualcomm.com>
>>>> Signed-off-by: Odelu Kukatla <odelu.kukatla@....qualcomm.com>
>>>> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
>>>> Signed-off-by: Raviteja Laggyshetty <raviteja.laggyshetty@....qualcomm.com>
>>>> ---
>>>>    .../bindings/interconnect/qcom,glymur-rpmh.yaml    | 172 +++++++++++++++++
>>>>    .../dt-bindings/interconnect/qcom,glymur-rpmh.h    | 205 +++++++++++++++++++++
>>>>    2 files changed, 377 insertions(+)
>>>
>>> This is breaking linux-next "make dt_binding_check". Looks like the
>>> clock header dependency in the example is not applied. Please drop
>>> this until the dependency is there.
>>
>> Thanks! And now i see why my script didn't catch this... now fixed and
>> patch dropped.
> 
> What are you using to apply patches? Because b4 would pull all
> dependencies, which would brake your branch as well, but at least you
> would see something odd happening here.

I am using b4, but in cherry-pick mode, so i just pipe the current email to
it. And i also noticed the prerequisite-change-id lines and the dependency
on gcc, but my local scripts (that do all kinds of checks) passed, because
of a bug that didn't properly log the dt_binding_check error, so i thought
the dependency is there. I recently modified it to run with not just the
DT_SCHEMA_FILES="Documentation/devicetree/bindings/interconnect/" but with
a few more schemas and very likely i introduced the logging bug at that time.

Thanks,
Georgi