linux-kernel - Re: [PATCH 07/15] ARM: dts: ls1021a: Rename esdhc@...0000 to mmc@...0000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5920180.DvuYhMxLoT@steina-w>
Date: Tue, 19 Aug 2025 07:46:25 +0200
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Shawn Guo <shawnguo@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 linux-arm-kernel@...ts.infradead.org
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 Frank Li <Frank.Li@....com>, Frank Li <Frank.Li@....com>
Subject:
 Re: [PATCH 07/15] ARM: dts: ls1021a: Rename esdhc@...0000 to mmc@...0000

Hi Frank,

Am Montag, 18. August 2025, 22:48:18 CEST schrieb Frank Li:
> Rename node name esdhc@...0000 to mmc@...0000 to fix below CHECK_DTBS
> warnings:
>   arch/arm/boot/dts/nxp/ls/ls1021a-tqmls1021a-mbls1021a-rgb-cdtech-fc21.dtb: esdhc@...0000 (fsl,ls1021a-esdhc): $nodename:0: 'esdhc@...0000' does not match '^mmc(@.*)?$'
> 	from schema $id: http://devicetree.org/schemas/mmc/fsl,esdhc.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  arch/arm/boot/dts/nxp/ls/ls1021a.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/ls/ls1021a.dtsi b/arch/arm/boot/dts/nxp/ls/ls1021a.dtsi
> index d095c6107745d75b108a430a5eb15e4f2511e81f..3921d9c4912713064dec1e10ac00cc0916d8974e 100644
> --- a/arch/arm/boot/dts/nxp/ls/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/nxp/ls/ls1021a.dtsi
> @@ -154,7 +154,7 @@ qspi: spi@...0000 {
>  			status = "disabled";
>  		};
>  
> -		esdhc: esdhc@...0000 {
> +		esdhc: mmc@...0000 {

As mentioned in the cover letter to [1] this would break some version of
u-boot because they explicitly reference '/soc/esdhc@...0000' node name.

Best regards
Alexander

>  			compatible = "fsl,ls1021a-esdhc", "fsl,esdhc";
>  			reg = <0x0 0x1560000 0x0 0x10000>;
>  			interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> 
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/