linux-kernel - Re: [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40342432bf4638b54615b70320f72095f18c0490.camel@mediatek.com>
Date: Tue, 19 Aug 2025 07:54:49 +0000
From: Shunxi Zhang (章顺喜)
	<ot_shunxi.zhang@...iatek.com>
To: Sean Wang <Sean.Wang@...iatek.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "lee@...nel.org" <lee@...nel.org>,
	"alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
	"krzk@...nel.org" <krzk@...nel.org>,
	Eddie Huang (黃智傑) <eddie.huang@...iatek.com>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-rtc@...r.kernel.org"
	<linux-rtc@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>,
	Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jh Hsu (許希孜) <Jh.Hsu@...iatek.com>,
	Vince-WL Liu (劉文龍) <Vince-WL.Liu@...iatek.com>
Subject: Re: [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC_BBPU
 register

On Mon, 2025-08-11 at 13:02 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 11/08/2025 10:15, ot_shunxi.zhang@...iatek.com wrote:
> > From: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> > 
> > This patch adds new bit definitions for the RTC_BBPU register in
> > the
> 
> Why? There is no user of these. Don't add useless defines.
> 
> > mt6397 RTC header file. The following bit definitions are
> > introduced:
> 
> Hm?
> 
> > 
> > Signed-off-by: Shunxi Zhang <ot_shunxi.zhang@...iatek.com>
> > ---
> >  include/linux/mfd/mt6397/rtc.h | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/mfd/mt6397/rtc.h
> > b/include/linux/mfd/mt6397/rtc.h
> > index 27883af44f87..001cef6b7302 100644
> > --- a/include/linux/mfd/mt6397/rtc.h
> > +++ b/include/linux/mfd/mt6397/rtc.h
> > @@ -15,8 +15,11 @@
> >  #include <linux/rtc.h>
> > 
> >  #define RTC_BBPU               0x0000
> > +#define RTC_BBPU_PWREN         BIT(0)
> > +#define RTC_BBPU_CLR           BIT(1)
> > +#define RTC_BBPU_RESET_AL      BIT(3)
> >  #define RTC_BBPU_CBUSY         BIT(6)
> > -#define RTC_BBPU_KEY            (0x43 << 8)
> > +#define RTC_BBPU_KEY           (0x43 << 8)
> 
> 
> Why?
> 
> 
> 
> Best regards,
> Krzysztof

Dear sir,
The MT6397 is an integration of several ICs and does not have a
separate IC specification. I will check the relevant IC datasheets
again. I will remove the useless define in next version.

Thanks for your commnets.

Best regards
Shunxi Zhangus