linux-kernel - Re: [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97cb6271-9881-40e0-83a6-e41f14c85865@kernel.org>
Date: Tue, 19 Aug 2025 10:16:06 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shunxi Zhang (章顺喜)
 <ot_shunxi.zhang@...iatek.com>, Sean Wang <Sean.Wang@...iatek.com>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 "lee@...nel.org" <lee@...nel.org>,
 "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
 Eddie Huang (黃智傑) <eddie.huang@...iatek.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 Sirius Wang (王皓昱) <Sirius.Wang@...iatek.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Jh Hsu (許希孜) <Jh.Hsu@...iatek.com>,
 Vince-WL Liu (劉文龍) <Vince-WL.Liu@...iatek.com>
Subject: Re: [PATCH v1 1/2] mfd: mt6397: Add new bit definitions for RTC_BBPU
 register

On 19/08/2025 09:54, Shunxi Zhang (章顺喜) wrote:
>>>  #define RTC_BBPU               0x0000
>>> +#define RTC_BBPU_PWREN         BIT(0)
>>> +#define RTC_BBPU_CLR           BIT(1)
>>> +#define RTC_BBPU_RESET_AL      BIT(3)
>>>  #define RTC_BBPU_CBUSY         BIT(6)
>>> -#define RTC_BBPU_KEY            (0x43 << 8)
>>> +#define RTC_BBPU_KEY           (0x43 << 8)
>>
>>
>> Why?
>>
>>
>>
>> Best regards,
>> Krzysztof
> 
> Dear sir,
> The MT6397 is an integration of several ICs and does not have a
> separate IC specification. I will check the relevant IC datasheets
> again. I will remove the useless define in next version.


I understand nothing from this reply. I do not see it related to my
questions at all. Do you want to say that you change indentation,
because MT6397 is integration? That makes absolutely NO SENSE!

Best regards,
Krzysztof