linux-kernel - Re: [PATCH v4] module: Rename EXPORT_SYMBOL_GPL_FOR_MODULES to EXPORT_SYMBOL_FOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250819-vorgibt-bewalden-d16b7673cc72@brauner>
Date: Tue, 19 Aug 2025 11:44:48 +0200
From: Christian Brauner <brauner@...nel.org>
To: Daniel Gomez <da.gomez@...nel.org>
Cc: Vlastimil Babka <vbabka@...e.cz>, 
	Christoph Hellwig <hch@...radead.org>, Peter Zijlstra <peterz@...radead.org>, 
	David Hildenbrand <david@...hat.com>, Shivank Garg <shivankg@....com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Jiri Slaby (SUSE)" <jirislaby@...nel.org>, 
	Stephen Rothwell <sfr@...b.auug.org.au>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-modules@...r.kernel.org, linux-kbuild@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	Nicolas Schier <nicolas.schier@...ux.dev>, Daniel Gomez <da.gomez@...sung.com>, 
	Linus Torvalds <torvalds@...ux-foundation.org>, Matthias Maennich <maennich@...gle.com>, 
	Jonathan Corbet <corbet@....net>, Luis Chamberlain <mcgrof@...nel.org>, 
	Petr Pavlu <petr.pavlu@...e.com>, Sami Tolvanen <samitolvanen@...gle.com>, 
	Nathan Chancellor <nathan@...nel.org>, Alexander Viro <viro@...iv.linux.org.uk>, 
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH v4] module: Rename EXPORT_SYMBOL_GPL_FOR_MODULES to
 EXPORT_SYMBOL_FOR_MODULES

On Fri, Aug 15, 2025 at 05:39:54PM +0200, Daniel Gomez wrote:
> 
> 
> On 15/08/2025 07.25, Christian Brauner wrote:
> > On Tue, Aug 12, 2025 at 09:54:43AM +0200, Daniel Gomez wrote:
> >> On 11/08/2025 07.18, Christian Brauner wrote:j
> >>> On Fri, 08 Aug 2025 15:28:47 +0200, Vlastimil Babka wrote:
> >>>> Christoph suggested that the explicit _GPL_ can be dropped from the
> >>>> module namespace export macro, as it's intended for in-tree modules
> >>>> only. It would be possible to restrict it technically, but it was
> >>>> pointed out [2] that some cases of using an out-of-tree build of an
> >>>> in-tree module with the same name are legitimate. But in that case those
> >>>> also have to be GPL anyway so it's unnecessary to spell it out in the
> >>>> macro name.
> >>>>
> >>>> [...]
> >>>
> >>> Ok, so last I remember we said that this is going upstream rather sooner
> >>> than later before we keep piling on users. If that's still the case I'll
> >>> take it via vfs.fixes unless I hear objections.
> >>
> >> This used to go through Masahiro's kbuild tree. However, since he is not
> >> available anymore [1] I think it makes sense that this goes through the modules
> >> tree. The only reason we waited until rc1 was released was because of Greg's
> >> advise [2]. Let me know if that makes sense to you and if so, I'll merge this
> >> ASAP.
> > 
> > At this point it would mean messing up all of vfs.fixes to drop it from
> > there. So I'd just leave it in there and send it to Linus.
> 
> Got it. I was waiting for confirmation before taking it into the modules tree,
> and I agree that at this point it makes sense to keep it in vfs.fixes.
> 
> > Next time I know where it'll end up.
> 
> Can you clarify what you mean by this?

Next time I know that you are responsible for taking such patches. :)