linux-kernel - Re: [PATCH bpf-next v5 1/4] fprobe: use rhltable for fprobe_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKUtTpAYaMdNgj2a@gondor.apana.org.au>
Date: Wed, 20 Aug 2025 10:05:02 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: "Masami Hiramatsu  , Google" <mhiramat@...nel.org>
Cc: olsajiri@...il.com, menglong8.dong@...il.com, mhiramat@...nel.org,
	rostedt@...dmis.org, mathieu.desnoyers@...icios.com,
	hca@...ux.ibm.com, revest@...omium.org,
	linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
	bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next v5 1/4] fprobe: use rhltable for fprobe_ip_table

Masami Hiramatsu  , Google <mhiramat@...nel.org> wrote:
>
> Good catch! Hmm, previously we guaranteed that the find_first_fprobe_node()
> must be called under rcu read locked or fprobe_mutex locked, so that the
> node list should not be changed. But according to the comment of
> rhltable_lookup(), we need to lock the rcu_read_lock() around that.

Just as is the case for RCU in general, rcu read locks are unnecessary
for rhashtable if you already hold the write-side locks.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt