linux-kernel - Re: [PATCH] scsi: qla4xxx: Replace snprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1qzx6wy9r.fsf@ca-mkp.ca.oracle.com>
Date: Tue, 19 Aug 2025 22:08:31 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Len Bao <len.bao@....us>
Cc: Nilesh Javali <njavali@...vell.com>,
        Manish Rangankar
 <mrangankar@...vell.com>,
        GR-QLogic-Storage-Upstream@...vell.com,
        "James
 E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        "Martin K.
 Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qla4xxx: Replace snprintf() with sysfs_emit()


Hi Len!

> Documentation/filesystems/sysfs.rst mentions that show() should only
> use sysfs_emit()

It's a "should", not a "shall".

sysfs.rst was recently amended to emphasize that this suggestion applies
to new implementations only.  See commit 2115dc3e3376 ("docs:
filesystems: sysfs: Recommend sysfs_emit() for new code only").

Thanks!

-- 
Martin K. Petersen