linux-kernel - Re: [PATCH] scsi: qla4xxx: Replace snprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKl4SticSmkNo3CP@ubuntu>
Date: Sat, 23 Aug 2025 08:14:02 +0000
From: Len Bao <len.bao@....us>
To: "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Len Bao <len.bao@....us>, Nilesh Javali <njavali@...vell.com>,
	Manish Rangankar <mrangankar@...vell.com>,
	GR-QLogic-Storage-Upstream@...vell.com,
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qla4xxx: Replace snprintf() with sysfs_emit()

Hi Martin,

On Tue, Aug 19, 2025 at 10:08:31PM -0400, Martin K. Petersen wrote:
> 
> Hi Len!
> 
> > Documentation/filesystems/sysfs.rst mentions that show() should only
> > use sysfs_emit()
> 
> It's a "should", not a "shall".
> 
> sysfs.rst was recently amended to emphasize that this suggestion applies
> to new implementations only.  See commit 2115dc3e3376 ("docs:
> filesystems: sysfs: Recommend sysfs_emit() for new code only").

Thanks for the guidance. Sorry for the invonvenience. It's my fault.

Regards,
Len

> 
> Thanks!
> 
> -- 
> Martin K. Petersen